Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated time and rolling_wavg to the new ways #160

Merged
merged 1 commit into from
Sep 5, 2023
Merged

Updated time and rolling_wavg to the new ways #160

merged 1 commit into from
Sep 5, 2023

Conversation

stanbrub
Copy link
Collaborator

@stanbrub stanbrub commented Sep 5, 2023

Fixed breaking changes introduce recently in DHC.

  • Fixed test that used from deephaven.time import now (Removed the import and use the Java now DateTimeUtils formula)
  • Fixed tests for rolling_wavg_tick that were using the old weight_col (Removed the param name)

@stanbrub stanbrub linked an issue Sep 5, 2023 that may be closed by this pull request
DHC Python Breaking Time and RollingWAvg Change #159
Closed
jmao-denver
jmao-denver approved these changes Sep 5, 2023
View reviewed changes
Copy link

@jmao-denver jmao-denver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stanbrub stanbrub merged commit 2dc89a2 into deephaven:main Sep 5, 2023
2 checks passed
@stanbrub stanbrub deleted the fix-tests-based-on-python-now-changes branch September 6, 2023 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmao-denver jmao-denver jmao-denver approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DHC Python Breaking Time and RollingWAvg Change
2 participants
@stanbrub @jmao-denver