Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nightly Slack Publish contains Deleted Benchmarks #189

Closed
stanbrub opened this issue Oct 18, 2023 · 0 comments · Fixed by #191
Closed

Nightly Slack Publish contains Deleted Benchmarks #189

stanbrub opened this issue Oct 18, 2023 · 0 comments · Fixed by #191
Assignees
Labels
bug Something isn't working

Comments

@stanbrub
Copy link
Collaborator

stanbrub commented Oct 18, 2023

The query that the nightly slack notification is derived from contains at least one benchmark that no longer exists. It certainly is possible that some long-standing benchmarks no longer exist or have been replaced by better ones (as in the case of parquet). Need to account for that.

Static_Benchmark                               Chng5d  Var5d     Rate  ChngRls  ScrProb
ParquetWrite- GZIP 2 Strs 2 Longs 2 Dbls...   -0.2030   0.3%  954,608    -1.6%     0.0%
  • Nighty queries are based in part on past days. Ensure inclusion of only benchmarks that have measurements for the latest day
  • Care must be taken not to eliminate previous days for legitimate benchmark names
  • The latest benchmarks are not necessarily the benchmarks from the day the nightly queries are run
    • If a nightly build fails, no benchmark data is pushed to GCloud for that day
    • That would make the latest benchmarks yesterday's benchmark list
@stanbrub stanbrub added the bug Something isn't working label Oct 18, 2023
@stanbrub stanbrub self-assigned this Oct 18, 2023
@stanbrub stanbrub linked a pull request Oct 18, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant