Some improvements to slack publish #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
stanbrub
commented
Oct 18, 2023
•
stanbrub
commented
- Improved benchmark_name truncation so that it doesn't put "..." on things that weren't truncated.
- Improved benchmark_name truncation so that any "..." is part of the string length max
- Fixed an issue where benchmarks that were removed were showing up in queries looking at the latest benchmarks
- Added better api.close() handling when running the queries for slack publish
- Moved some reusable functions to the benchmark_tables.py main query and added some table cleanup
This was
linked to
issues
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.