Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Select/Update/DateTime Bechmark Improvements #185

Merged
merged 12 commits into from
Oct 27, 2023
Merged

Select/Update/DateTime Bechmark Improvements #185

merged 12 commits into from
Oct 27, 2023

Conversation

stanbrub
Copy link
Collaborator

@stanbrub stanbrub commented Oct 16, 2023 •
edited
Loading

  • Rewrote select/update/view/update_view formula tests to be more obviously consistent.
  • Removed former update tests and packages where appropriate
  • Re-scaled DateTimeUtils tests to remove some variability between runs

Notes for Reviewer:

  • Mainly looking for whether or not the benchmarks are capturing the difference between these operations when inline formulas are used.

This was linked to issues Oct 16, 2023
Rescale DateTimeUtils Benchmarks #184
Closed
Improve Select/Update/View/UpdateView Benchmarks #186
Closed
@stanbrub stanbrub requested a review from rcaudy October 16, 2023 23:38
@stanbrub stanbrub self-assigned this Oct 20, 2023
@stanbrub stanbrub requested a review from rcaudy October 26, 2023 23:07
@stanbrub stanbrub merged commit 0af11f7 into deephaven:main Oct 27, 2023
2 checks passed
@stanbrub stanbrub deleted the select-update-test-mprovements branch October 27, 2023 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rcaudy rcaudy rcaudy approved these changes

Assignees

@stanbrub stanbrub

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve Select/Update/View/UpdateView Benchmarks Rescale DateTimeUtils Benchmarks
2 participants
@stanbrub @rcaudy