Skip to content

Commit

Permalink
refactor: rename label_alignment to label_align (#799)
Browse files Browse the repository at this point in the history
- Fixes #717 
- Rename `label_alignment` to `label_align` for `form` and `picker`
  • Loading branch information
wusteven815 authored Sep 5, 2024
1 parent c02587b commit e31ac51
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
6 changes: 3 additions & 3 deletions plugins/ui/src/deephaven/ui/components/form.py
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ def form(
auto_complete: AutoCompleteModes | None = None,
auto_capitalize: AutoCapitalizeModes | None = None,
label_position: LabelPosition = "top",
label_alignment: Alignment = "start",
label_align: Alignment = "start",
necessity_indicator: NecessityIndicator = "icon",
on_submit: Callable[[dict[str, str]], None] | None = None,
on_reset: Callable[[dict[str, str]], None] | None = None,
Expand Down Expand Up @@ -109,7 +109,7 @@ def form(
auto_complete: Indicates whether input elements can by default have their values automatically completed by the browser.
auto_capitalize: Controls whether inputted text is automatically capitalized and, if so, in what manner.
label_position: The label's overall position relative to the element it is labeling.
label_alignment: The label's horizontal alignment relative to the element it is labeling.
label_align: The label's horizontal alignment relative to the element it is labeling.
necessity_indicator: Whether the required state should be shown as an icon or text.
on_submit: The function to call when the form is submitted.
on_reset: The function to call when the form is reset.
Expand Down Expand Up @@ -177,7 +177,7 @@ def form(
auto_complete=auto_complete,
auto_capitalize=auto_capitalize,
label_position=label_position,
label_alignment=label_alignment,
label_align=label_align,
necessity_indicator=necessity_indicator,
on_submit=on_submit,
on_reset=on_reset,
Expand Down
4 changes: 2 additions & 2 deletions plugins/ui/src/deephaven/ui/components/picker.py
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ def picker(
placeholder: str | None = None,
is_loading: bool | None = None,
label_position: LabelPosition = "top",
label_alignment: Alignment = "start",
label_align: Alignment = "start",
necessity_indicator: NecessityIndicator = "icon",
contextual_help: Element | None = None,
on_open_change: Callable[[bool], None] | None = None,
Expand Down Expand Up @@ -162,7 +162,7 @@ def picker(
placeholder: Placeholder text for the input.
is_loading: Whether the Picker is in a loading state.
label_position: The label's overall position relative to the element it is labeling.
label_alignment: The label's horizontal alignment relative to the element it is labeling.
label_align: The label's horizontal alignment relative to the element it is labeling.
necessity_indicator: Whether the required state should be shown as an icon or text.
contextual_help: A ContextualHelp element to place next to the label.
on_open_change: Handler that is called when the open state changes.
Expand Down

0 comments on commit e31ac51

Please sign in to comment.