feat: ui.labeled_value #1029
Open
feat: ui.labeled_value #1029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mofojed
requested changes
Nov 21, 2024
| def labeled_value( | ||
| value: str | List[str] | int | None = None, | ||
| label: Element | None = None, | ||
| # format_options: TODO Add date formatting options |
There was a problem hiding this comment.
Follow up ticket for this? Or do you plan to commit before merging?
At the least you should include number format options right now.
There was a problem hiding this comment.
I was planning to have a follow-up ticket for it, I can add the number format options right now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #938 and Closes #869
Additional Notes: