Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: create CODEOWNERS #775

Closed
wants to merge 5 commits into from
Closed

ci: create CODEOWNERS #775

wants to merge 5 commits into from

Conversation

margaretkennedy
Copy link
Contributor

No description provided.

@margaretkennedy margaretkennedy changed the title Create CODEOWNERS feat: create CODEOWNERS Aug 26, 2024
@margaretkennedy
Copy link
Contributor Author

Would "chore" be more appropriate?

@dsmmcken
Copy link
Contributor

Would "chore" be more appropriate?

ci:

@margaretkennedy margaretkennedy changed the title feat: create CODEOWNERS ci: create CODEOWNERS Aug 26, 2024
mofojed
mofojed requested changes Aug 27, 2024
View reviewed changes
.github/CODEOWNERS Outdated Show resolved Hide resolved
@margaretkennedy @mofojed
Update CODEOWNERS
a1244f1 
Co-authored-by: Mike Bender <[email protected]>
dsmmcken
dsmmcken previously approved these changes Aug 27, 2024
View reviewed changes
mofojed
mofojed previously approved these changes Aug 27, 2024
View reviewed changes
mattrunyon
mattrunyon requested changes Aug 27, 2024
View reviewed changes
Copy link
Collaborator

@mattrunyon mattrunyon left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, we should not have docs with only 1 codeowner. Puts a complete stop on things if Margaret is out for any reason

@dsmmcken
Copy link
Contributor

dsmmcken commented Aug 27, 2024 •
edited
Loading

That's a fair point. It's more like we wanted her to be auto-added as a reviewer for any doc change but you are right this would be a hard requirement which isn't necessarily what we want either. I am gonna recommend just closing this PR for now.

@dsmmcken dsmmcken closed this Aug 27, 2024
@mattrunyon
Copy link
Collaborator

mattrunyon commented Aug 27, 2024 •
edited
Loading

I think you could achieve this w/ a custom action that uses github-script (info) with paths and github.rest.pulls.requestReviewers (docs)

If you want I can probably put that together pretty quickly. Seems pretty straightforward

@mattrunyon mattrunyon deleted the docs-codeowner branch August 29, 2024 21:35
@margaretkennedy margaretkennedy restored the docs-codeowner branch September 3, 2024 16:01
@margaretkennedy
Update CODEOWNERS
74b7d7a 
Add backup codeowners
@dsmmcken
Copy link
Contributor

dsmmcken commented Sep 3, 2024

Re-closing, we've decided we didn't want a blocking code owner as part of this repos workflow.

We did add an action though that adds you as a reviewer for any docs changes automatically.

See:
#778

@dsmmcken dsmmcken closed this Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsmmcken dsmmcken Awaiting requested review from dsmmcken

@mattrunyon mattrunyon Awaiting requested review from mattrunyon

@mofojed mofojed Awaiting requested review from mofojed

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@margaretkennedy @dsmmcken @mattrunyon @mofojed