feat: DateRangePicker Implementation #780

dgodinez-dh · 2024-08-28T20:08:36Z

Closes #764

mofojed

Looking good overall! A few things to cleanup/change.

mofojed · 2024-08-29T19:00:15Z

plugins/ui/docs/components/date_range_picker.md

+
+## HTML forms
+
+Date range pickr supports the start_name and end_name props for integration with HTML forms. The values will be submitted to the server as `ISO 8601` formatted strings according to the granularity of the value. For example, if the date range picker allows selecting only dates then strings such as "2023-02-03" will be submitted, and if it allows selecting times then strings such as "2023-02-03T08:45:00"


Suggested change

Date range pickr supports the start_name and end_name props for integration with HTML forms. The values will be submitted to the server as `ISO 8601` formatted strings according to the granularity of the value. For example, if the date range picker allows selecting only dates then strings such as "2023-02-03" will be submitted, and if it allows selecting times then strings such as "2023-02-03T08:45:00"

Date range picker supports the `start_name` and `end_name` props for integration with HTML forms. The values will be submitted to the server as `ISO 8601` formatted strings according to the granularity of the value. For example, if the date range picker allows selecting only dates then strings such as "2023-02-03" will be submitted, and if it allows selecting times then strings such as "2023-02-03T08:45:00"

mofojed · 2024-08-29T19:03:30Z

plugins/ui/docs/components/date_range_picker.md

+```python
+from deephaven import ui
+
+my_date_range_picker_forms = ui.date_range_picker(
+    label="Trip dates", start_name="startDate", end_name="endDate"
+)
+```


This example doesn't make a ton of sense in isolation (I know it's copied from Spectrum). I'd wrap this in a ui.form, e.g.

Suggested change

```python

from deephaven import ui

my_date_range_picker_forms = ui.date_range_picker(

label="Trip dates", start_name="startDate", end_name="endDate"

)

```

```python

from deephaven import ui

my_date_range_picker_forms = ui.form(

ui.date_range_picker(

label="Trip dates", start_name="startDate", end_name="endDate"

),

ui.button("Submit", type="submit"),

on_submit=print

)

```

mofojed · 2024-08-29T19:11:36Z

plugins/ui/src/deephaven/ui/_internal/utils.py

@@ -381,9 +396,57 @@ def convert_list_prop(
    return [str(_convert_to_java_date(date)) for date in value]


+def convert_date_range(


Add some tests in test_date_picker.py and/or test_utils.py to have tests for this functionality.

Added a test_date_range_picker.py similar to test_date_picker.py
The date functionality does not appear to be tested directly in test_utils.py but in the unit test for components.

mofojed · 2024-08-29T19:21:13Z

tests/ui.spec.ts-snapshots/UI-all-components-render-1-chromium-linux.png

We're pushing more things off the page as we add more components.
We should split up the ui_components into a couple components so we have a little more room and we're actually testing all components.

plugins/ui/DESIGN.md

margaretkennedy · 2024-08-30T15:46:52Z

plugins/ui/DESIGN.md

+The range is a dictionary with a `start` date and an `end` date. e.g. `{ "start": "2024-01-02", "end": "2024-01-05" }`
+
+The date range picker accepts the following date types as inputs:  
+`None`, `LocalDate`, `ZoneDateTime`, `Instant`, `int`, `str`, `datetime.datetime`, `numpy.datetime64`, `pandas.Timestamp`


bullet list?

plugins/ui/DESIGN.md

plugins/ui/docs/components/date_range_picker.md

Co-authored-by: margaretkennedy <[email protected]>

mofojed

Looks good codewise, wait for @margaretkennedy 's approval of docs before merging.

plugins/ui/docs/components/date_range_picker.md

margaretkennedy · 2024-09-03T21:29:07Z

plugins/ui/docs/components/date_range_picker.md

+
+The `range` is a dictionary with a `start` date and an `end` date. e.g. `{ "start": "2024-01-02", "end": "2024-01-05" }`
+
+The date range picker accepts the following date types as inputs:  


The date range picker accepts the following date types as inputs:

None

LocalDate

ZoneDateTime

Instant

int

str

datetime.datetime

numpy.datetime64

pandas.Timestamp

plugins/ui/docs/components/date_range_picker.md

Co-authored-by: margaretkennedy <[email protected]>

dgodinez-dh added 20 commits August 26, 2024 10:59

Date Range Picker Design Doc Update

efce486

initaly python props

3855446

upate converter for range

665db76

fix type check

5470088

init py

3cc2d1c

initial js code

fdb46c6

docs update

08a7219

remove unavailabe dates

0baba58

initial js refactor

9eaaa6a

more JS refactor

57e76c2

fix comments

02f2b5f

some doc updates

0264a7c

fix granularity

d3be195

date range useDebouncedOnChange

b3afeb0

fix example

84d5277

date picker useDebouncedOnChange

ae4dfeb

more doc updates

33c2ae5

more doc examples

30891fa

merge latest

cfde121

update images

34f2096

dgodinez-dh requested a review from mofojed August 28, 2024 20:08

mofojed requested changes Aug 29, 2024

View reviewed changes

doc updates

c6fb50f

github-actions bot requested a review from margaretkennedy August 29, 2024 19:48

add test_date_range_picker

1ad4b34

dgodinez-dh removed the request for review from margaretkennedy August 29, 2024 20:40

break render all into 2 screenshots

b5eefc2

github-actions bot requested a review from margaretkennedy August 29, 2024 21:10

dgodinez-dh requested review from mofojed and removed request for margaretkennedy August 29, 2024 21:17

remove column types from second image

f45f188

dgodinez-dh requested review from mofojed and removed request for margaretkennedy August 30, 2024 14:36

margaretkennedy reviewed Aug 30, 2024

View reviewed changes

dgodinez-dh and others added 13 commits August 30, 2024 10:02

Update plugins/ui/DESIGN.md

071f75b

Co-authored-by: margaretkennedy <[email protected]>

Update plugins/ui/DESIGN.md

a5ebf58

Co-authored-by: margaretkennedy <[email protected]>

Update plugins/ui/DESIGN.md

15bdaee

Co-authored-by: margaretkennedy <[email protected]>

Update plugins/ui/DESIGN.md

989bfd7

Co-authored-by: margaretkennedy <[email protected]>

Update plugins/ui/docs/components/date_range_picker.md

f7c07a7

Co-authored-by: margaretkennedy <[email protected]>

Update plugins/ui/docs/components/date_range_picker.md

c9be66c

Co-authored-by: margaretkennedy <[email protected]>

Update plugins/ui/docs/components/date_range_picker.md

e0999f0

Co-authored-by: margaretkennedy <[email protected]>

Update plugins/ui/docs/components/date_range_picker.md

ab61f74

Co-authored-by: margaretkennedy <[email protected]>

Update plugins/ui/docs/components/date_range_picker.md

82c4619

Co-authored-by: margaretkennedy <[email protected]>

Update plugins/ui/DESIGN.md

60667e2

Co-authored-by: margaretkennedy <[email protected]>

fix merge

de1e40d

Merge branch 'main' into dag_DateRangePicker

220b843

fix black

49600e2

mofojed previously approved these changes Sep 3, 2024

View reviewed changes

margaretkennedy reviewed Sep 3, 2024

View reviewed changes

Apply suggestions from code review

598ca22

Co-authored-by: margaretkennedy <[email protected]>

dgodinez-dh dismissed mofojed’s stale review via 598ca22 September 4, 2024 12:22

dgodinez-dh and others added 3 commits September 4, 2024 06:40

use bullet list

84ff383

merge latest

4cef77c

Update plugins/ui/docs/components/date_range_picker.md

0a01954

Co-authored-by: margaretkennedy <[email protected]>

dgodinez-dh requested review from margaretkennedy and mofojed September 4, 2024 12:52

margaretkennedy approved these changes Sep 4, 2024

View reviewed changes

dgodinez-dh merged commit 088d623 into deephaven:main Sep 4, 2024
17 checks passed

dgodinez-dh deleted the dag_DateRangePicker branch September 4, 2024 13:10

mofojed mentioned this pull request Sep 23, 2024

docs: ui.date_range_picker #853

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: DateRangePicker Implementation #780

feat: DateRangePicker Implementation #780

dgodinez-dh commented Aug 28, 2024

mofojed left a comment

mofojed Aug 29, 2024

dgodinez-dh Aug 29, 2024

mofojed Aug 29, 2024

dgodinez-dh Aug 29, 2024

mofojed Aug 29, 2024

dgodinez-dh Aug 29, 2024 •

edited

Loading

mofojed Aug 29, 2024

margaretkennedy Aug 30, 2024

dgodinez-dh Sep 4, 2024

mofojed left a comment

margaretkennedy Sep 3, 2024

dgodinez-dh Sep 4, 2024


		## HTML forms

		Date range pickr supports the start_name and end_name props for integration with HTML forms. The values will be submitted to the server as `ISO 8601` formatted strings according to the granularity of the value. For example, if the date range picker allows selecting only dates then strings such as "2023-02-03" will be submitted, and if it allows selecting times then strings such as "2023-02-03T08:45:00"

		@@ -381,9 +396,57 @@ def convert_list_prop(
		return [str(_convert_to_java_date(date)) for date in value]


		def convert_date_range(


		The `range` is a dictionary with a `start` date and an `end` date. e.g. `{ "start": "2024-01-02", "end": "2024-01-05" }`

		The date range picker accepts the following date types as inputs:

feat: DateRangePicker Implementation #780

feat: DateRangePicker Implementation #780

Conversation

dgodinez-dh commented Aug 28, 2024

mofojed left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dgodinez-dh Aug 29, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mofojed left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dgodinez-dh Aug 29, 2024 •

edited

Loading