Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allows keys to be set in props #810

Merged
merged 29 commits into from
Sep 20, 2024
Merged

fix: allows keys to be set in props #810

merged 29 commits into from
Sep 20, 2024

Conversation

wusteven815
Copy link
Contributor

@wusteven815 wusteven815 commented Sep 6, 2024 •
edited
Loading

@wusteven815 wusteven815 self-assigned this Sep 6, 2024
mofojed
mofojed previously requested changes Sep 10, 2024
View reviewed changes
plugins/ui/src/deephaven/ui/components/_maker.py Outdated Show resolved Hide resolved
plugins/ui/src/deephaven/ui/components/_maker.py Outdated Show resolved Hide resolved
plugins/ui/src/deephaven/ui/components/flex.py Outdated Show resolved Hide resolved
@wusteven815 wusteven815 marked this pull request as ready for review September 18, 2024 19:06
mofojed
mofojed requested changes Sep 18, 2024
View reviewed changes
plugins/ui/src/deephaven/ui/components/column.py Outdated Show resolved Hide resolved
plugins/ui/src/deephaven/ui/components/row.py Outdated Show resolved Hide resolved
plugins/ui/src/deephaven/ui/components/section.py Outdated Show resolved Hide resolved
plugins/ui/src/deephaven/ui/components/tab.py Outdated Show resolved Hide resolved
plugins/ui/src/deephaven/ui/elements/Element.py Outdated Show resolved Hide resolved
plugins/ui/src/deephaven/ui/renderer/Renderer.py Outdated Show resolved Hide resolved
plugins/ui/src/deephaven/ui/renderer/Renderer.py Outdated Show resolved Hide resolved
plugins/ui/src/deephaven/ui/renderer/Renderer.py Outdated Show resolved Hide resolved
plugins/ui/src/deephaven/ui/elements/UITable.py Outdated Show resolved Hide resolved
mofojed
mofojed approved these changes Sep 19, 2024
View reviewed changes
Copy link
Member

@mofojed mofojed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! I like the added e2e tests as well.

@wusteven815 wusteven815 merged commit ca06eea into deephaven:main Sep 20, 2024
17 checks passed
@mofojed mofojed mentioned this pull request Sep 20, 2024
Merged
@wusteven815 wusteven815 deleted the 731-add-key-prop branch September 20, 2024 20:12
@mofojed mofojed mentioned this pull request Sep 23, 2024
Closed
wusteven815 added a commit to wusteven815/deephaven-plugins that referenced this pull request Sep 24, 2024
@wusteven815
fix: allows keys to be set in props (deephaven#810)
15262dd 
- Fixes deephaven#731 
  - Extract and save `key` prop
  - Modify key generation to use the `key` prop if it exists
- Allow `map` to be a valid component
  - Converts directly to a list while checking for unique props
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mofojed mofojed mofojed approved these changes

Assignees

@wusteven815 wusteven815

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to delete an item from the middle of a list in deephaven.ui, no React keys
2 participants
@wusteven815 @mofojed