fix: add wrapper to toggle_button #821

wusteven815 · 2024-09-11T20:56:16Z

Add ui.action_button should wrap string props in ui.text #812
- Change toggle_button to use a wrapper, like the other buttons
- Update UI-all-components-render-2 E2E test to reflect text being wrapped

mofojed · 2024-09-13T13:14:02Z

@wusteven815 can you check with action_button and button as well? They may need similar wrapping

wusteven815 · 2024-09-13T13:32:13Z

@wusteven815 can you check with action_button and button as well? They may need similar wrapping

Seems to be just the toggle_button

fix: add toggleButton to wrap text

5c3a378

wusteven815 self-assigned this Sep 11, 2024

wusteven815 linked an issue Sep 11, 2024 that may be closed by this pull request

ui.action_button should wrap string props in ui.text #812

Closed

wusteven815 marked this pull request as ready for review September 12, 2024 14:45

wusteven815 requested review from a team and dgodinez-dh and removed request for a team September 12, 2024 14:47

dgodinez-dh previously approved these changes Sep 12, 2024

View reviewed changes

wusteven815 marked this pull request as draft September 13, 2024 13:39

wusteven815 added 2 commits September 13, 2024 11:42

add ToggleButton wrapper

4112b2b

update toggle button e2e

9185b98

wusteven815 dismissed dgodinez-dh’s stale review via 9185b98 September 13, 2024 15:46

wusteven815 marked this pull request as ready for review September 13, 2024 16:26

wusteven815 changed the title ~~fix: add toggleButton to wrap text~~ fix: add wrapper to toggle_button Sep 13, 2024

wusteven815 requested a review from dgodinez-dh September 13, 2024 16:27

dgodinez-dh approved these changes Sep 13, 2024

View reviewed changes

wusteven815 merged commit fff1d6c into deephaven:main Sep 13, 2024
19 checks passed

wusteven815 deleted the 812-auto-wrap-action-button branch September 17, 2024 15:17

Provide feedback