-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: dx
now respects the webgl flag
#934
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will need package bump but looks okay.
I think this is almost ready, but is there anything else I need for the package bump? I'm unsure if I've done everything because as is this doesn't work locally due to the web-client-ui changes I made when just running in this repo. Do I need to require a future engine version that would would itself use at least 0.97.0 web-client-ui? The versioning interactions there is a bit fuzzy to me. |
Fixes #612
The current implementation has the following behavior, although note that this will not work fully until deephaven/web-client-ui#2255 is merged
scattergl
->scatter
) and replaced again if reenabled (scatter
->scattergl
)scatter3d
orscattermapbox
) the prompt in the image below will appear. Once accepted, the acceptance persists for this specific chart, even if webgl is toggled again.Note that disabling and reenabling through the settings without clicking Continue doesn't count as an acceptance, so if the prompt appears, the setting is enabled, then the setting is disabled again, the prompt will still appear.