refactor: Refactored to use an extension controller + require return types

[bmingles]

• Refactored extension module to use a controller class. This should make things easier to test and encourages better architecture
• Enabled linting rule to require return types + fixed offending code

supports #79

[github-actions]

End-to-end Test Summary

Tests 📝	Passed ✅	Failed ❌	Skipped ⏭️	Pending ⏳	Other ❓	Flaky 🍂	Duration ⏱️
3	3	0	0	0	0	0	02:03:52

A ctrf plugin

Detailed Test Results

Name	Status	ms	Flaky 🍂
should be able to load VSCode	passed ✅	1102
should only be visible when a supported file type is active: test.groovy	passed ✅	2661
should only be visible when a supported file type is active: test.py	passed ✅	1194

A ctrf plugin

Failed Test Summary

No failed tests ✨

Flaky Test Summary

No flaky tests detected. ✨

[github-actions]

Unit Test Summary

Tests 📝	Passed ✅	Failed ❌	Skipped ⏭️	Pending ⏳	Other ❓	Flaky 🍂	Duration ⏱️
25	25	0	0	0	0	0	00:00:00

A ctrf plugin

Detailed Test Results

Name	Status	ms	Flaky 🍂
src/services/Config.spec.ts: Config > should return core servers: Empty config	passed ✅	2
src/services/Config.spec.ts: Config > should return core servers: String config	passed ✅	1
src/services/Config.spec.ts: Config > should return core servers: Default url	passed ✅	0
src/services/Config.spec.ts: Config > should return core servers: Full config	passed ✅	1
src/util/ExtendedMap.spec.ts: ExtendedMap Test Suite > getOrThrow	passed ✅	1
src/util/assertUtil.spec.ts: assertDefined > should not throw if value is defined: {}	passed ✅	2
src/util/assertUtil.spec.ts: assertDefined > should not throw if value is defined: test	passed ✅	1
src/util/assertUtil.spec.ts: assertDefined > should not throw if value is defined: 999	passed ✅	0
src/util/assertUtil.spec.ts: assertDefined > should not throw if value is defined: true	passed ✅	0
src/util/assertUtil.spec.ts: assertDefined > should not throw if value is defined: false	passed ✅	1
src/util/assertUtil.spec.ts: assertDefined > should not throw if value is defined: 2024-08-08T22:22:22.273Z	passed ✅	0
src/util/assertUtil.spec.ts: assertDefined > should throw an error for null or undefined values: null	passed ✅	1
src/util/assertUtil.spec.ts: assertDefined > should throw an error for null or undefined values: undefined	passed ✅	0
src/util/downloadUtils.spec.ts: getTempDir > should create temp directory if it does not already exist: true, undefined	passed ✅	6
src/util/downloadUtils.spec.ts: getTempDir > should create temp directory if it does not already exist: true, subDirectory	passed ✅	1
src/util/downloadUtils.spec.ts: getTempDir > should create temp directory if it does not already exist: false, undefined	passed ✅	0
src/util/downloadUtils.spec.ts: getTempDir > should create temp directory if it does not already exist: false, subDirectory	passed ✅	1
src/util/downloadUtils.spec.ts: getTempDir > should remove directory if recreate is true: true, undefined, /home/runner/work/vscode-deephaven/vscode-deephaven/src/tmp	passed ✅	1
src/util/downloadUtils.spec.ts: getTempDir > should remove directory if recreate is true: true, subDirectory, /home/runner/work/vscode-deephaven/vscode-deephaven/src/tmp/subDirectory	passed ✅	3
src/util/downloadUtils.spec.ts: getTempDir > should remove directory if recreate is true: false, undefined, /home/runner/work/vscode-deephaven/vscode-deephaven/src/tmp	passed ✅	0
src/util/downloadUtils.spec.ts: getTempDir > should remove directory if recreate is true: false, subDirectory, /home/runner/work/vscode-deephaven/vscode-deephaven/src/tmp/subDirectory	passed ✅	1
src/util/urlUtils.spec.ts: urlUtils > should convert url to host_port string: http://localhost:4000, localhost_4000	passed ✅	2
src/util/urlUtils.spec.ts: urlUtils > should convert url to host_port string: https://localhost:5000, localhost_5000	passed ✅	0
src/util/urlUtils.spec.ts: urlUtils > should convert url to host_port string: http://www.acme.com:6000, www_acme_com_6000	passed ✅	0
src/util/urlUtils.spec.ts: urlUtils > should convert url to host_port string: https://www.acme.com:7000, www_acme_com_7000	passed ✅	0

A ctrf plugin

Failed Test Summary

No failed tests ✨

Flaky Test Summary

No flaky tests detected. ✨

[mofojed]

Pretty much the same as assertNotNull in @deephaven/utils, not sure it's worth re-defining.

[bmingles]

Looks like installing @deephaven/utils is going to take some extra work:

I've created @deephaven/utils - errors when installing in vscode extension #2185 to address changes needed in web-client-ui and Replace assertDefined with @deephaven/utils assertNotNull #95 as a follow up in the extension.