Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the package directory to each packages package.json #460

Merged
merged 1 commit into from
Mar 2, 2022
Merged

Add the package directory to each packages package.json #460

merged 1 commit into from
Mar 2, 2022

Conversation

mofojed
Copy link
Member

@mofojed mofojed commented Mar 1, 2022 •
edited
Loading

@mofojed mofojed added this to the March 2022 milestone Mar 1, 2022
@mofojed mofojed requested a review from spasovski March 1, 2022 15:28
@mofojed mofojed self-assigned this Mar 1, 2022
@mofojed
Copy link
Member Author

mofojed commented Mar 1, 2022

Kicked off an alpha build to test published links: https://github.com/deephaven/web-client-ui/actions/runs/1917076585

@mofojed
Copy link
Member Author

mofojed commented Mar 1, 2022

Hmmm it looks like the HTML link transformer doesn't take directory into account: https://github.com/npm/marky-markdown/blob/96cd45a1e4a826a663ae50916c382420f10825ea/lib/plugin/github.js#L72

Workaround is to use absolute links, which I will in a follow up... but I'm also going to submit a PR on marky-mark to take directory into account, because it's dumb otherwise.

@mofojed
Copy link
Member Author

mofojed commented Mar 1, 2022

Created PR to address this in marky-markdown: npm/marky-markdown#455

Not sure it will actually be updated though, since that package hasn't been updated in a while. Seems odd that nobody has tried to fix this before, and the workaround is to just provide absolute links.

spasovski
spasovski previously approved these changes Mar 2, 2022
View reviewed changes
Copy link
Contributor

@spasovski spasovski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat. Monorepo support.

@mofojed
Add the package directory to each packages package.json
ff656ea 
- Update the repository information for each package.json to specify the directory that package is in
- Should make relative links work correctly when packages are published
- Partial deephaven#445
@mofojed mofojed force-pushed the update-package-directories branch from c1cc3fb to ff656ea Compare March 2, 2022 19:45
spasovski
spasovski approved these changes Mar 2, 2022
View reviewed changes
Copy link
Contributor

@spasovski spasovski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@mofojed mofojed merged commit 2132a04 into deephaven:main Mar 2, 2022
@mofojed mofojed deleted the update-package-directories branch March 2, 2022 21:28
@mofojed mofojed mentioned this pull request Mar 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spasovski spasovski spasovski approved these changes

Assignees

@mofojed mofojed

Labels
internal web-client-ui
Projects
None yet
Milestone
March 2022
Development

Successfully merging this pull request may close these issues.
2 participants
@mofojed @spasovski