[Deepin-Kernel-SIG] [linux 6.6-y] [Upstream] block: fix 'kmem_cache of name 'bio-108' already exists'

[opsiff]

mainline inclusion
from mainline-v6.14-rc5
category: bugfix

Device mapper bioset often has big bio_slab size, which can be more than 1000, then 8byte can't hold the slab name any more, cause the kmem_cache allocation warning of 'kmem_cache of name 'bio-108' already exists'.

Fix the warning by extending bio_slab->name to 12 bytes, but fix output of /proc/slabinfo

Reported-by: Guangwu Zhang [email protected]

Link: https://lore.kernel.org/r/[email protected]

(cherry picked from commit b654f7a51ffb386131de42aa98ed831f8c126546)

Summary by Sourcery

Bug Fixes:

• Fixes kmem_cache allocation warning of 'kmem_cache of name 'bio-108' already exists' by extending bio_slab->name to 12 bytes.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request addresses a kmem_cache allocation warning caused by the bio_slab name field being too small for large slab sizes. The name field in the bio_slab struct has been increased from 8 to 12 bytes to resolve this issue.

Updated class diagram for bio_slab struct

classDiagram
  class bio_slab {
    struct kmem_cache* slab
    unsigned int slab_ref
    unsigned int slab_size
    char name[12]
  }
  note for bio_slab "'name' field increased from 8 to 12 bytes"

Loading

File-Level Changes

Change	Details	Files
Increased the size of the name field in the bio_slab structure to accommodate larger slab sizes and prevent kmem_cache allocation warnings.	Increased the size of the name field in the bio_slab struct from 8 bytes to 12 bytes.	block/bio.c

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!
• Generate a plan of action for an issue: Comment @sourcery-ai plan on
  an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[deepin-ci-robot]

deepin pr auto review

关键摘要:

• bio_slab 结构体中的 name 字段从 8 字节扩展到 12 字节，需要确认是否有足够的理由来支持这一变化，例如是否需要存储更长的名称。

是否建议立即修改:

• 是，如果扩展 name 字段是为了满足新的需求，需要确保这一变化不会导致其他问题，例如内存使用增加、数据截断等。同时，需要检查所有使用 bio_slab 结构体的地方，确保它们能够正确处理新的字段长度。

[sourcery-ai]

Hey @opsiff - I've reviewed your changes - here's some feedback:

Overall Comments:

• Consider adding a comment explaining why the size was increased to 12 bytes specifically.

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[winnscode]

lgtm :)

[deepin-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: winnscode
Once this PR has been reviewed and has the lgtm label, please ask for approval from opsiff. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• deepin/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment