Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds multiple custom images in cli #9

Merged
merged 4 commits into from
Nov 30, 2019
Merged

Conversation

victorcmoura
Copy link
Contributor

@victorcmoura victorcmoura commented Nov 30, 2019

This pull request implements a cli feature to allow users to specify which images they want to colorize.

Description

This PR adds the following command option in cli:

  • python3 main.py f <filename1> <filename2>

This command will run Kara and colorize the images located in and . Multiple files are supported, so there could be a <filename3>, <filename4>, etc...

Related Issue

#5

Motivation and Context

It enhances user experience and customization.

How Has This Been Tested?

I tested it manually.

Screenshots (if appropriate):

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.

@victorcmoura victorcmoura added the enhancement New feature or request label Nov 30, 2019
@victorcmoura
Copy link
Contributor Author

Just updated the README.md with the CLI usage

Copy link
Collaborator

@sconetto sconetto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

- remove folder uppercase

Signed-off-by: João Pedro Sconetto <[email protected]>
@sconetto sconetto merged commit b2c1dab into feature/alpha Nov 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants