Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

os.getenv replaced with os.environ #178

Merged
merged 20 commits into from
Sep 5, 2023
Merged

os.getenv replaced with os.environ #178

merged 20 commits into from
Sep 5, 2023

Conversation

pseusys
Copy link
Collaborator

@pseusys pseusys commented Jul 26, 2023

Description

From now on absence of required environmental variables has become more obvious.

Checklist

  • I have covered the code with tests
  • I have added comments to my code to help others understand it
  • I have updated the documentation to reflect the changes
  • I have performed a self-review of the changes

@pseusys pseusys added the enhancement New feature or request label Jul 26, 2023
@pseusys pseusys requested a review from kudep July 26, 2023 14:29
@pseusys pseusys self-assigned this Jul 26, 2023
@pseusys pseusys marked this pull request as ready for review July 27, 2023 20:15
RLKRo
RLKRo requested changes Jul 27, 2023
View reviewed changes
tutorials/messengers/telegram/1_basic.py Outdated Show resolved Hide resolved
tests/context_storages/test_dbs.py Show resolved Hide resolved
@pseusys

This comment was marked as spam.

Sign in to view
@pseusys pseusys requested review from RLKRo and kudep August 14, 2023 07:11
@pseusys pseusys requested review from kudep and RLKRo August 21, 2023 08:31
RLKRo
RLKRo requested changes Aug 25, 2023
View reviewed changes
tests/messengers/telegram/test_tutorials.py Outdated Show resolved Hide resolved
tests/messengers/telegram/test_tutorials.py Outdated Show resolved Hide resolved
tests/context_storages/test_dbs.py Outdated Show resolved Hide resolved
@pseusys pseusys requested a review from RLKRo September 5, 2023 09:25
@kudep kudep merged commit 9e533e0 into dev Sep 5, 2023
16 checks passed
@kudep kudep deleted the feat/getenv_replaced_with_environ_for_clear_none_checks branch September 5, 2023 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RLKRo RLKRo RLKRo approved these changes

@kudep kudep kudep approved these changes

Assignees

@pseusys pseusys

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pseusys @kudep @RLKRo