Merge extended_conditions into main repository #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace df_engine with dff.core.engine - Replace df_runner with dff.core.pipeline - Replace df_extended_conditions with dff.script.logic.extended_conditions
Fix references to files inside examples/extended_conditions since those were moved from examples. Also rename example_utils.py to _extended_conditions_utils.py.
Also add a step that generates a gdf_account.json file from secret.
Rename the second `testing_model` function to `hf_matcher`
RLKRo
added
enhancement
* adjust line length; * adapt to new directory structure; * move tests and examples to script/extras/conditions; * reformat with black; * rework imports;
RLKRo
commented
Oct 25, 2024
chatsky/conditions/ml.py
Outdated
|
|
||
|
|
||
| @singledispatch | ||
| def has_cls_label(model: ExtrasBaseModel, label, threshold: float = 0.9): |
There was a problem hiding this comment.
Add validator for label (present in the model config).
RLKRo
commented
Oct 28, 2024
RLKRo
commented
Nov 1, 2024
chatsky/conditions/ml.py
Outdated
| def __init__(self, *args): | ||
| super().__init__(*args) | ||
|
|
||
| async def call(self): |
There was a problem hiding this comment.
Incorrect call signature (should accept context and return bool).
chatsky/conditions/ml.py
Outdated
| super().__init__(*args) | ||
|
|
||
| async def call(self): | ||
| async def has_cls_label_innner(ctx: Context, _) -> bool: |
chatsky/conditions/ml.py
Outdated
Comment on lines
81
to
82
| if negative_examples is None: | ||
| negative_examples = [] |
There was a problem hiding this comment.
Use Pydantic's Field default factory instead.
| TRANSITIONS: { | ||
| # We get to one of the dialog branches depending on the annotation | ||
| ("service", "buy", 1.2): i_cnd.has_cls_label( | ||
| api_model, "LABEL_1", threshold=0.95 |
There was a problem hiding this comment.
These models should be passed to pipeline (same as #376) to allow has cls label to accept model name (instead of model instance).
RLKRo
commented
Nov 1, 2024
Comment on lines
+60
to
+78
| async def save(self, path: str, **kwargs) -> None: | ||
| """ | ||
| Save the model to a specified location. | ||
|
|
||
| :param path: string-formatted path. If tokenizer state | ||
| needs to be saved, the path is used as the base. | ||
| """ | ||
| raise NotImplementedError | ||
|
|
||
| @classmethod | ||
| async def load(cls, path: str, namespace_key: str): | ||
| """ | ||
| Load a model from the specified location and instantiate the model. | ||
|
|
||
| :param str: Path to saving directory. | ||
| :param namespace_key: Name of the namespace in that the model will be using. | ||
| Will be forwarded to the model on construction. | ||
| """ | ||
| raise NotImplementedError |
There was a problem hiding this comment.
Remove unnecessary methods.
There was a problem hiding this comment.
Move these files from models/remote_api to models -- there are no other models.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Add README.md
Sync dependencies with df_stats (stats requires
httpx<=0.23.0andrequests>=2.28.1while extended_conditions requireshttpx>=0.23.0andrequests<=2.28.1)Skip tests if required dependencies are not installed, env vars are not set or docker is not running
Add
try: except ImportErrorwhen importing extended_conditions dependenciesFix huggingface tests:
testing_model, I renamed the second one tohf_matcherReplace _extended_conditions_utils.py imports when All example utils moved to
dff#34 is mergedAt the moment rasa docker image building includes model training. This doesn't seem like good practice.