-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added partially extracted slots support for the GroupSlots #394
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It appears this PR is a release PR (change its base from master
if that is not the case).
Here's a release checklist:
- Update package version
- Update
poetry.lock
- Change PR merge option
- Update template repo
- Search for objects to be deprecated
- Test parts not covered with pytest:
- web_api tutorials
- Test integrations with external services (telegram; stats)
llm_response must inherit from BaseResponse |
- Simplify slot regexps - More extensive tests for slot storage changes
I don't like name regex in this tutorial. For example, here I use email and bitcoin address which both have fairly unique regex (i.e. unlikely false positives -> more options with requests): (regex for these can be found here; although email regex is pretty long, this might be better) Also, I don't think that |
Consider adding way of defining minimal slots required for the group extraction to succeed |
Description
Added flag
allow_partially_extracted
to theGroupSlot
class constructor. IfTrue
non extracted slots from Group Slot would not be overwritten with default values.Checklist