Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Instance anonymization #17

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

Instance anonymization #17

wants to merge 16 commits into from

Conversation

maks-operlejn-ds
Copy link

No description provided.

mateusz-wosinski-ds
mateusz-wosinski-ds reviewed Sep 11, 2023
View reviewed changes
Copy link

@mateusz-wosinski-ds mateusz-wosinski-ds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, probably PresidioAnonymizer should have a temporary mapping for each anonymization

libs/experimental/langchain_experimental/data_anonymizer/deanonymizer_mapping.py Outdated Show resolved Hide resolved
libs/experimental/langchain_experimental/data_anonymizer/presidio.py Outdated Show resolved Hide resolved
@maks-operlejn-ds maks-operlejn-ds changed the title WIP: Instance anonymization Instance anonymization Sep 12, 2023
@maks-operlejn-ds maks-operlejn-ds marked this pull request as ready for review September 12, 2023 08:49
mateusz-wosinski-ds
mateusz-wosinski-ds reviewed Sep 12, 2023
View reviewed changes
Copy link

@mateusz-wosinski-ds mateusz-wosinski-ds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls add an example in a notebook (maybe one of previously added?)

libs/experimental/langchain_experimental/data_anonymizer/deanonymizer_mapping.py Outdated
"""Update the deanonymizer mapping with new values
Duplicated values will not be added
"""
new_values_seen = set()
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need this? Due to the fact that the same value can appear for different entity_type?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the case of default recognizers, not likely, but who knows what users will come up with when adding their own 😛

libs/experimental/langchain_experimental/data_anonymizer/presidio.py Show resolved Hide resolved
mateusz-wosinski-ds
mateusz-wosinski-ds approved these changes Sep 12, 2023
View reviewed changes
Copy link

@mateusz-wosinski-ds mateusz-wosinski-ds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor things 🙌

docs/extras/guides/privacy/presidio_data_anonymization/index.ipynb Outdated Show resolved Hide resolved
libs/experimental/tests/unit_tests/test_data_anonymizer.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mateusz-wosinski-ds mateusz-wosinski-ds mateusz-wosinski-ds approved these changes

@eryk-dsai eryk-dsai eryk-dsai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maks-operlejn-ds @eryk-dsai @mateusz-wosinski-ds @baskaryan