feat(core): Implement generic Options class #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Coverage SummaryDiff against mainResults for commit: b60a1e3 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
|
Trivy scanning results. .venv/lib/python3.10/site-packages/PyJWT-2.9.0.dist-info/METADATA (secrets)Total: 1 (MEDIUM: 1, HIGH: 0, CRITICAL: 0) MEDIUM: JWT (jwt-token) .venv/lib/python3.10/site-packages/litellm/llms/huggingface/huggingface_llms_metadata/hf_text_generation_models.txt (secrets)Total: 1 (MEDIUM: 0, HIGH: 0, CRITICAL: 1) CRITICAL: HuggingFace (hugging-face-access-token) .venv/lib/python3.10/site-packages/litellm/proxy/_types.py (secrets)Total: 1 (MEDIUM: 1, HIGH: 0, CRITICAL: 0) MEDIUM: Slack (slack-web-hook) |
akonarski-ds
changed the title
micpst
reviewed
Dec 17, 2024
|
I don’t see any refactoring for the rerankers interface—was that intentional or just missed? It looks like they’ll need the new interface too. |
I missed that, was focused only on changes to the ragbits-core. Thanks for catching that, I'll refactor rerankers too |
micpst
reviewed
Dec 17, 2024
ludwiktrammer
requested changes
Dec 17, 2024
|
@micpst @ludwiktrammer I've implemented the |
akonarski-ds
force-pushed
the
feat/implement_generic_options
branch
from
f6a94fb to
be3b2d2
Compare
ludwiktrammer
approved these changes
Dec 18, 2024
packages/ragbits-core/src/ragbits/core/utils/config_handling.py
Outdated
Show resolved
Hide resolved
micpst
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR intoduces generic Options class that can be used with Embeddings, LLMs, VectoreStores that allows for convenient management of params passed to underlying APIs . It enables strong typing, but also allows for specifying extra params without changing core package code.