feat: add cli event handler #256
Open
+294
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Coverage SummaryDiff against mainResults for commit: 4ca2cef Minimum allowed coverage is ♻️ This comment has been updated with latest results |
|
Trivy scanning results. .venv/lib/python3.10/site-packages/litellm/proxy/_types.py (secrets)Total: 1 (MEDIUM: 1, HIGH: 0, CRITICAL: 0) MEDIUM: Slack (slack-web-hook) .venv/lib/python3.10/site-packages/PyJWT-2.9.0.dist-info/METADATA (secrets)Total: 1 (MEDIUM: 1, HIGH: 0, CRITICAL: 0) MEDIUM: JWT (jwt-token) .venv/lib/python3.10/site-packages/litellm/llms/huggingface/huggingface_llms_metadata/hf_text_generation_models.txt (secrets)Total: 1 (MEDIUM: 0, HIGH: 0, CRITICAL: 1) CRITICAL: HuggingFace (hugging-face-access-token) |
kdziedzic68
reviewed
Dec 17, 2024
| # /// | ||
| """ | ||
|
|
||
| import asyncio |
There was a problem hiding this comment.
are we sure that we need script example of cli-related feature ? even if - perhaps setting trace handler is just one line - perhaps we shall eventually add setting trace handlers to already existing scripts
There was a problem hiding this comment.
Probably at the final version we don;t need. I just wanted to see how CLI event handler is working. I can remove it before merge.
kdziedzic68
reviewed
Dec 17, 2024
| "parent": self.parent.name if self.parent else None, | ||
| } | ||
|
|
||
| def to_tree(self, tree: Tree | None = None, color: str = "bold blue") -> Tree | None: |
There was a problem hiding this comment.
to_tree name - to me suggests construction of a new object from the class instance
There was a problem hiding this comment.
Could you give me better name?
kdziedzic68
reviewed
Dec 17, 2024
kdziedzic68
reviewed
Dec 17, 2024
| tree = Tree(f"[{color}]{self.name}[/{color}] (Duration: {self.end_time - self.start_time:.3f}s)") | ||
|
|
||
| elif tree and self.end_time: | ||
| child_tree = tree.add(f"[{color}]{self.name}[/{color}] (Duration: {self.end_time - self.start_time:.3f}s)") |
There was a problem hiding this comment.
why do we need to instantiate child_tree ?
There was a problem hiding this comment.
When we have nested spans and we don't have child_tree we will get flat tree, i.e:
A Duration: 0.000s
├── B Duration: 0.000s
│
├── C Duration: 0.000s
│
├── D Duration: 0.000s
│
└── E Duration: 0.000s
Instead of:
A Duration: 0.000s
├── B Duration: 0.000s
│ └── C Duration: 0.000s
│
└── D Duration: 0.000s
└── E Duration: 0.000s
micpst
reviewed
Dec 18, 2024
|
i noticed we’re using rich tree for rendering traces - it looks great! But it doesn’t show any info about inputs and outputs. maybe we could think about how to include those in the layout? btw, the tree is rendered at the end of processing, maybe there is an option to do it irl - https://rich.readthedocs.io/en/stable/live.html 🤔 |
…cli-event-handler
micpst
reviewed
Dec 20, 2024
| else: | ||
| child_tree = tree.add( | ||
| f"[{color}]{self.name}[/{color}] Duration: {duration:.3f}s\n" | ||
| f"[{secondary_color}]Inputs: {self.inputs}\nOutputs: {self.outputs})[/{secondary_color}]" |
There was a problem hiding this comment.
maybe we can make this more readable, lets try to print each input/output key separately and use different colors for keys and values
There was a problem hiding this comment.
we can also add some parameters to the CLITraceHandler to control whether we want the input/output data to be printed + optional truncation
| self.start_time: float = time.perf_counter() | ||
| self.end_time: float | None = None | ||
| self.children: list[CLISpan] = [] | ||
| self.status: str = "started" |
There was a problem hiding this comment.
lets make it enum, e.g. SpanStatus
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added:
TODO:
add rendering inputs and outputs