Skip to content

Commit

Permalink
Merge branch 'main' into dev/fastembed
Browse files Browse the repository at this point in the history
  • Loading branch information
nickprock authored Feb 8, 2024
2 parents 7153197 + 52508a6 commit 547728b
Show file tree
Hide file tree
Showing 3 changed files with 66 additions and 40 deletions.
32 changes: 18 additions & 14 deletions .github/workflows/instructor_embedders.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ on:
- cron: "0 0 * * *"
pull_request:
paths:
- 'integrations/instructor_embedders/**'
- '.github/workflows/instructor_embedders.yml'
- "integrations/instructor_embedders/**"
- ".github/workflows/instructor_embedders.yml"

defaults:
run:
Expand All @@ -16,19 +16,23 @@ jobs:
test:
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v4
- name: Checkout
uses: actions/checkout@v4

- name: Setup Python
uses: actions/setup-python@v5
with:
python-version: '3.10'
- name: Setup Python
uses: actions/setup-python@v5
with:
python-version: "3.10"

- name: Install Hatch
run: pip install --upgrade hatch
- name: Install Hatch
run: pip install --upgrade hatch

- name: Lint
run: hatch run lint:all
- name: Lint
run: hatch run lint:all

- name: Run tests
run: hatch run cov
- name: Generate docs
if: runner.os == 'Linux'
run: hatch run docs

- name: Run tests
run: hatch run cov
30 changes: 30 additions & 0 deletions integrations/instructor_embedders/pydoc/config.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
loaders:
- type: haystack_pydoc_tools.loaders.CustomPythonLoader
search_path: [../src]
modules:
[
"haystack_integrations.components.embedders.instructor_embedders",
"haystack_integrations.components.embedders.instructor_embedders.embedding_backend",
]
ignore_when_discovered: ["__init__"]
processors:
- type: filter
expression:
documented_only: true
do_not_filter_modules: false
skip_empty_modules: true
- type: smart
- type: crossref
renderer:
type: haystack_pydoc_tools.renderers.ReadmePreviewRenderer
excerpt: Embedders integration for Haystack
category_slug: haystack-integrations
title: Embedders
slug: integrations-instructor-embedders
order: 90
markdown:
descriptive_class_title: false
descriptive_module_title: true
add_method_class_prefix: true
add_member_class_prefix: false
filename: _readme_instructor_embedders.md
44 changes: 18 additions & 26 deletions integrations/instructor_embedders/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,7 @@ readme = "README.md"
requires-python = ">=3.7"
license = "Apache-2.0"
keywords = []
authors = [
{ name = "deepset GmbH", email = "[email protected]" },
]
authors = [{ name = "deepset GmbH", email = "[email protected]" }]
classifiers = [
"Development Status :: 4 - Beta",
"Programming Language :: Python",
Expand Down Expand Up @@ -43,7 +41,7 @@ dependencies = [
"tqdm",
"rich",

"InstructorEmbedding"
"InstructorEmbedding",
]

[project.optional-dependencies]
Expand All @@ -66,38 +64,26 @@ root = "../.."
git_describe_command = 'git describe --tags --match="integrations/instructor_embedders-v[0-9]*"'

[tool.hatch.envs.default]
dependencies = ["pytest", "pytest-cov"]
dependencies = ["pytest", "pytest-cov", "haystack-pydoc-tools"]

[tool.hatch.envs.default.scripts]
cov = "pytest --cov-report=term-missing --cov-config=pyproject.toml --cov=instructor-embedders --cov=tests"
no-cov = "cov --no-cov"
test = "pytest {args:tests}"
docs = "pydoc-markdown pydoc/config.yml"

[[tool.hatch.envs.test.matrix]]
python = ["38", "39", "310", "311"]

[tool.hatch.envs.lint]
detached = true
dependencies = [
"black>=23.1.0",
"mypy>=1.0.0",
"ruff>=0.0.243",
]
dependencies = ["black>=23.1.0", "mypy>=1.0.0", "ruff>=0.0.243"]

[tool.hatch.envs.lint.scripts]
typing = "mypy --install-types --non-interactive --explicit-package-bases {args:src/ tests}"
style = [
"ruff {args:.}",
"black --check --diff {args:.}",
]
fmt = [
"black {args:.}",
"ruff --fix {args:.}",
"style",
]
all = [
"style",
"typing",
]
style = ["ruff {args:.}", "black --check --diff {args:.}"]
fmt = ["black {args:.}", "ruff --fix {args:.}", "style"]
all = ["style", "typing"]

[tool.coverage.run]
branch = true
Expand Down Expand Up @@ -141,9 +127,15 @@ ignore = [
# Allow boolean positional values in function calls, like `dict.get(... True)`
"FBT003",
# Ignore checks for possible passwords
"S105", "S106", "S107",
"S105",
"S106",
"S107",
# Ignore complexity
"C901", "PLR0911", "PLR0912", "PLR0913", "PLR0915",
"C901",
"PLR0911",
"PLR0912",
"PLR0913",
"PLR0915",
]
unfixable = [
# Don't touch unused imports
Expand Down Expand Up @@ -178,4 +170,4 @@ module = [
"pytest.*",
"numpy.*",
]
ignore_missing_imports = true
ignore_missing_imports = true

0 comments on commit 547728b

Please sign in to comment.