in/not_in filters

integrations/pinecone/src/pinecone_haystack/filters.py

@@ -105,6 +105,7 @@ def _greater_than_equal(field: str, value: Any) -> Dict[str, Any]:
 
     return {field: {"$gte": value}}
 
+
 def _less_than(field: str, value: Any) -> Dict[str, Any]:
     supported_types = (int, float)
     if not isinstance(value, supported_types):
@@ -129,13 +130,47 @@ def _less_than_equal(field: str, value: Any) -> Dict[str, Any]:
     return {field: {"$lte": value}}
 
 
+def _not_in(field: str, value: Any) -> Dict[str, Any]:
+    if not isinstance(value, list):
+        msg = f"{field}'s value must be a list when using 'not in' comparator in Pinecone"
+        raise FilterError(msg)
+
+    supported_types = (int, float, str)
+    for v in value:
+        if not isinstance(v, supported_types):
+            msg = (
+                f"Unsupported type for 'not in' comparison: {type(v)}. "
+                f"Types supported by Pinecone are: {supported_types}"
+            )
+            raise FilterError(msg)
+
+    return {field: {"$nin": value}}
+
+
+def _in(field: str, value: Any) -> Dict[str, Any]:
+    if not isinstance(value, list):
+        msg = f"{field}'s value must be a list when using 'in' comparator in Pinecone"
+        raise FilterError(msg)
+
+    supported_types = (int, float, str)
+    for v in value:
+        if not isinstance(v, supported_types):
+            msg = (
+                f"Unsupported type for 'in' comparison: {type(v)}. "
+                f"Types supported by Pinecone are: {supported_types}"
+            )
+            raise FilterError(msg)
+
+    return {field: {"$in": value}}
+
+
 COMPARISON_OPERATORS = {
     "==": _equal,
     "!=": _not_equal,
     ">": _greater_than,
     ">=": _greater_than_equal,
     "<": _less_than,
     "<=": _less_than_equal,
-    # "in": _in,
-    # "not in": _not_in,
+    "in": _in,
+    "not in": _not_in,
 }

integrations/pinecone/tests/test_filters.py

@@ -25,7 +25,6 @@ def assert_documents_are_equal(self, received: List[Document], expected: List[Do
             if "number" in doc.meta:
                 doc.meta["number"] = int(doc.meta["number"])
 
-
         # let's compare the documents
         assert len(received) == len(expected)
         for received_doc in received:
@@ -83,4 +82,3 @@ def test_comparison_less_than_equal_with_iso_date(self, document_store, filterab
     @pytest.mark.skip(reason="Pinecone does not support comparison with null values")
     def test_comparison_less_than_equal_with_none(self, document_store, filterable_docs):
         ...
-