Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check license of top-level dependencies for all integrations #1005

Closed
julian-risch opened this issue Aug 19, 2024 · 0 comments · Fixed by #1020
Closed

Check license of top-level dependencies for all integrations #1005

julian-risch opened this issue Aug 19, 2024 · 0 comments · Fixed by #1020
Assignees
Labels
feature request Ideas to improve an integration P2

Comments

@julian-risch
Copy link
Member

julian-risch commented Aug 19, 2024

Is your feature request related to a problem? Please describe.
Similar to the license compliance workflow in Haystack core, we should check the license of top-level dependencies in haystack-core-integrations.
Here is the workflow in Haystack: https://github.com/deepset-ai/haystack/blob/1d4883f1789dd281f0a3de00854ec547bfb19213/.github/workflows/license_compliance.yml#L49
The result of the top-level dependency check could be shown for each integration in the inventory table in the readme of the repo.

Describe the solution you'd like

  • Add a license check workflow that is similar to the one we use in Haystack.
  • Merging all dependencies into one long list and doing only a single check instead of one check per integration

Describe alternatives you've considered
Not adding the checks, which poses legal risks and adoption risks.

Additional context
We should check with @ArzelaAscoIi if he can help. We should also check how to connect this with FOSSA. It's different than Haystack core because haystack-core-integrations has the code for multiple pypi packages in one repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Ideas to improve an integration P2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants