Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add license compliance workflow #1020

Merged
merged 30 commits into from
Aug 27, 2024
Merged

ci: add license compliance workflow #1020

merged 30 commits into from
Aug 27, 2024

Conversation

anakin87
Copy link
Member

@anakin87 anakin87 commented Aug 23, 2024

Related Issues

Proposed Changes:

Add a single workflow that checks the license compliance on PRs and nightly

Mostly based on https://github.com/deepset-ai/haystack/blob/main/.github/workflows/license_compliance.yml

How did you test it?

I tested it using this branch
test on PRs: https://github.com/deepset-ai/haystack-core-integrations/actions/runs/10563356632/job/29263394604?pr=1020
test nightly: https://github.com/deepset-ai/haystack-core-integrations/actions/runs/10563449108/job/29263683646?pr=1020

Checklist

@anakin87 anakin87 changed the title license compliance workflow ci: add license compliance workflow Aug 26, 2024
@anakin87 anakin87 marked this pull request as ready for review August 26, 2024 16:36
@anakin87 anakin87 requested a review from a team as a code owner August 26, 2024 16:36
@anakin87 anakin87 requested review from julian-risch and silvanocerza and removed request for a team and julian-risch August 26, 2024 16:36
.github/workflows/CI_license_compliance.yml Outdated Show resolved Hide resolved

# - haystack-pydoc-tools is Apache 2.0 but the license is not available on PyPI
# - tqdm is MLP but there are no better alternatives
# - psycopg is LGPL-3.0
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unsure about this. In its independent scan, FOSSA is fine with this license.

Copy link
Contributor

@silvanocerza silvanocerza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good, feel free to merge after adding the missing new lines.

@anakin87 anakin87 merged commit ee08a47 into main Aug 27, 2024
3 checks passed
@anakin87 anakin87 deleted the license-compliance branch August 27, 2024 10:57
Amnah199 pushed a commit that referenced this pull request Oct 2, 2024
* draft

* try changing pyproject

* filter changed files

* simplify script

* small fix

* try dep

* try

* handle scheduled and PR

* try skip

* simplify

* try all deps

* try all

* retry

* fix

* retry

* define exclusions as venv

* retry excl

* see if exclusions work

* try datadog

* really try datadog

* retry datadog

* test on PR

* test on PR

* TEST ON PR

* TEST SCHEDULED

* revert temp changes

* newlines and print

* restore ollama/pyproject

* retry on all deps

* restore
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check license of top-level dependencies for all integrations
2 participants