-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add license compliance workflow #1020
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anakin87
changed the title
license compliance workflow
ci: add license compliance workflow
Aug 26, 2024
anakin87
requested review from
julian-risch and
silvanocerza
and removed request for
a team and
julian-risch
August 26, 2024 16:36
anakin87
commented
Aug 26, 2024
|
||
# - haystack-pydoc-tools is Apache 2.0 but the license is not available on PyPI | ||
# - tqdm is MLP but there are no better alternatives | ||
# - psycopg is LGPL-3.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unsure about this. In its independent scan, FOSSA is fine with this license.
silvanocerza
approved these changes
Aug 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good, feel free to merge after adding the missing new lines.
Amnah199
pushed a commit
that referenced
this pull request
Oct 2, 2024
* draft * try changing pyproject * filter changed files * simplify script * small fix * try dep * try * handle scheduled and PR * try skip * simplify * try all deps * try all * retry * fix * retry * define exclusions as venv * retry excl * see if exclusions work * try datadog * really try datadog * retry datadog * test on PR * test on PR * TEST ON PR * TEST SCHEDULED * revert temp changes * newlines and print * restore ollama/pyproject * retry on all deps * restore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
Add a single workflow that checks the license compliance on PRs and nightly
Mostly based on https://github.com/deepset-ai/haystack/blob/main/.github/workflows/license_compliance.yml
How did you test it?
I tested it using this branch
test on PRs: https://github.com/deepset-ai/haystack-core-integrations/actions/runs/10563356632/job/29263394604?pr=1020
test nightly: https://github.com/deepset-ai/haystack-core-integrations/actions/runs/10563449108/job/29263683646?pr=1020
Checklist
fix:
,feat:
,build:
,chore:
,ci:
,docs:
,style:
,refactor:
,perf:
,test:
.