Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for VertexAIGeminiChatGenerator #1019

Closed
Amnah199 opened this issue Aug 23, 2024 · 1 comment · Fixed by #1042
Closed

Add tests for VertexAIGeminiChatGenerator #1019

Amnah199 opened this issue Aug 23, 2024 · 1 comment · Fixed by #1042
Assignees
Labels

Comments

@Amnah199
Copy link
Contributor

Is your feature request related to a problem? Please describe.
At the moment, we don't have any tests for VertexAIGeminiChatGenerator, which poses the risk of undetected bugs in future.

Describe the solution you'd like
Similar unit tests as VertexAIGeminiGenerator.

Describe alternatives you've considered
Rely on manual testing.

@anakin87
Copy link
Member

I also feel that the GoogleAIGeminiChatGenerator tests can be improved.

An example:

messages += res["replies"] + [ChatMessage.from_function(content=weather, name="get_current_weather")]
res = gemini_chat.run(messages=messages)
assert len(res["replies"]) > 0

Here, I think we should check the role and the format of the returned message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants