test: Add tests for VertexAIChatGeminiGenerator and migrate from preview #1042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@julian-risch worst case scenario, merging changes with testing failing only on windows is an option? |
|
You should also add a serialization/deserialization test of a pipeline containing a VertexAIChatGeminiGenerator |
github-actions
bot
added
the
type:documentation
|
@Amnah199 here's an example of the type of test I mentioned above: |
The QdrantDocumentStore did not properly implement the DocumentStore protocol.
* fix: Add NONE option to EmbeddingTruncateMode * refactor: Validate input with _missing_ method * test: Add EmbeddingTruncateMode test * refactor: Revert "refactor: Validate input with _missing_ method" This reverts commit 8334a50. * Update integrations/nvidia/src/haystack_integrations/components/embedders/nvidia/truncate.py --------- Co-authored-by: Madeesh Kannan <[email protected]>
github-actions
bot
added
integration:qdrant
integration:weaviate
integration:nvidia
labels
Amnah199
changed the title
vblagoje
reviewed
Sep 6, 2024
| assert gemini._model_name == "gemini-1.5-flash" | ||
| assert gemini._project_id == "TestID123" | ||
| assert gemini._safety_settings == {HarmCategory.HARM_CATEGORY_DANGEROUS_CONTENT: HarmBlockThreshold.BLOCK_ONLY_HIGH} | ||
| # assert repr(gemini._tools) == repr([Tool(function_declarations=[GET_CURRENT_WEATHER_FUNC])]) |
There was a problem hiding this comment.
Was by mistake. Just fixed it 👍
Amnah199
added a commit
that referenced
this pull request
Oct 2, 2024
…iew package in vertexai (#1042) * Add tests for chat generator and migrate from preview package to a stable version of vertexai generative_model
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
previewpackage to stable versionVertexAIChatGeminiGeneratorHow did you test it?
Notes for the reviewer
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.