feat: update default embedding model to nvidia/nv-embedqa-e5-v5 #1015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@shadeMe ptal. i worked out the lint issues - an old version of hatch + isort. |
shadeMe
approved these changes
Aug 26, 2024
Amnah199
pushed a commit
that referenced
this pull request
Oct 2, 2024
* add tests for preview embedding apis * update default model to nvidia/nv-embedqa-e5-v5 * lint fixes w/ latest versions of black, isort, hatch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes:
Improved embedding models are available. Update the default model to nvidia/nv-embedqa-e5-v5.
Additionally, tests for other available models.
How did you test it?
NVIDIA_API_KEY=... hatch run testNotes for the reviewer
This may be a breaking change if someone is specifically relying on the NV-Embed-QA default.
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.