Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Pinecone - remove legacy filter support #1069

Merged
merged 6 commits into from
Sep 12, 2024
Merged

chore: Pinecone - remove legacy filter support #1069

merged 6 commits into from
Sep 12, 2024

Conversation

vblagoje
Copy link
Member

@vblagoje vblagoje commented Sep 9, 2024 •
edited
Loading

@vblagoje vblagoje mentioned this pull request Sep 9, 2024
Merged
@vblagoje vblagoje marked this pull request as ready for review September 9, 2024 13:52
@vblagoje vblagoje requested a review from a team as a code owner September 9, 2024 13:52
@vblagoje vblagoje requested review from davidsbatista and removed request for a team September 9, 2024 13:52
davidsbatista
davidsbatista reviewed Sep 10, 2024
View reviewed changes
integrations/pinecone/src/haystack_integrations/document_stores/pinecone/document_store.py Outdated
@@ -201,6 +200,10 @@ def filter_documents(self, filters: Optional[Dict[str, Any]] = None) -> List[Doc
:returns: A list of Documents that match the given filters.
"""

if filters and "operator" not in filters and "conditions" not in filters:
msg = "Legacy filters support has been removed. Please see documentation for new filter syntax."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest adding a link to the documentation in addition to the message to see the documentation

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done @davidsbatista thanks for the suggestion, now applied across all relevant integrations

@vblagoje vblagoje merged commit 69946c0 into main Sep 12, 2024
6 checks passed
@vblagoje vblagoje deleted the remove_legacy_filters_pinecone branch September 12, 2024 12:59
Amnah199 pushed a commit that referenced this pull request Oct 2, 2024
@vblagoje @Amnah199
chore: Pinecone - remove legacy filter support (#1069)
59a5b31 
* Remove legacy filter support

* Linting

* Improve error message

* Improve error message - lint

* Change message to be more generic

* Error msg fmt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidsbatista davidsbatista davidsbatista approved these changes

Assignees
No one assigned
Labels
integration:pinecone
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vblagoje @davidsbatista