chore: Weaviate - remove legacy filter support #1070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vblagoje
requested review from
Amnah199 and
silvanocerza
and removed request for
a team
Amnah199
reviewed
Sep 10, 2024
Comment on lines
390
to
391
| msg = "Legacy filters support has been removed. Please see documentation for new filter syntax." | ||
| raise ValueError(msg) |
There was a problem hiding this comment.
Can we mention if we are talking about weaviate documentation or haystack docs, as this sounds a bit ambiguous?
There was a problem hiding this comment.
yes, included a link to docs now, see the diff @Amnah199
Amnah199
approved these changes
Sep 11, 2024
silvanocerza
approved these changes
Sep 12, 2024
Amnah199
pushed a commit
that referenced
this pull request
Oct 2, 2024
* Remove legacy filter support * Linting * Remove outdated test * Improve error message * Error msg fmt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
convertfrom fromhaystack-ai)