Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: filters in chroma integration #1072

Merged
merged 18 commits into from
Sep 20, 2024
Merged

fix: filters in chroma integration #1072

merged 18 commits into from
Sep 20, 2024

Conversation

Amnah199
Copy link
Contributor

@Amnah199 Amnah199 commented Sep 9, 2024

Related Issues

Proposed Changes:

  • Fixed the logical and conversion errors in normalize_filters function.
  • The example in docstrings were also not accurate as the chromadb filters require array inputs for logical operators (reference docs). I updated the examples to follow the chroma db docs.

How did you test it?

  • added test for checking nested operators in filters

Notes for the reviewer

If you have any particular example to test with filters, you can notify me to add them in tests.

Checklist

@Amnah199 Amnah199 requested a review from a team as a code owner September 9, 2024 13:41
@Amnah199 Amnah199 requested review from shadeMe and removed request for a team September 9, 2024 13:41
@github-actions github-actions bot added type:documentation Improvements or additions to documentation integration:chroma labels Sep 9, 2024
shadeMe
shadeMe suggested changes Sep 9, 2024
View reviewed changes
integrations/chroma/src/haystack_integrations/document_stores/chroma/document_store.py Outdated Show resolved Hide resolved
integrations/chroma/src/haystack_integrations/document_stores/chroma/document_store.py Outdated Show resolved Hide resolved
integrations/chroma/src/haystack_integrations/document_stores/chroma/document_store.py Outdated Show resolved Hide resolved
integrations/chroma/src/haystack_integrations/document_stores/chroma/document_store.py Outdated Show resolved Hide resolved
integrations/chroma/src/haystack_integrations/document_stores/chroma/document_store.py Outdated Show resolved Hide resolved
integrations/chroma/src/haystack_integrations/document_stores/chroma/document_store.py Outdated Show resolved Hide resolved
integrations/chroma/src/haystack_integrations/document_stores/chroma/document_store.py Outdated Show resolved Hide resolved
integrations/chroma/src/haystack_integrations/document_stores/chroma/document_store.py Outdated Show resolved Hide resolved
@Amnah199 Amnah199 requested a review from shadeMe September 10, 2024 09:20
@Amnah199 Amnah199 marked this pull request as draft September 13, 2024 13:48
@Amnah199 Amnah199 marked this pull request as ready for review September 16, 2024 13:42
shadeMe
shadeMe suggested changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@shadeMe shadeMe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much better! Some more comments.

integrations/chroma/src/haystack_integrations/document_stores/chroma/document_store.py Outdated Show resolved Hide resolved
integrations/chroma/src/haystack_integrations/document_stores/chroma/document_store.py Outdated Show resolved Hide resolved
integrations/chroma/src/haystack_integrations/document_stores/chroma/filters.py Outdated Show resolved Hide resolved
integrations/chroma/src/haystack_integrations/document_stores/chroma/filters.py Outdated Show resolved Hide resolved
integrations/chroma/src/haystack_integrations/document_stores/chroma/filters.py Show resolved Hide resolved
integrations/chroma/src/haystack_integrations/document_stores/chroma/filters.py Outdated Show resolved Hide resolved
integrations/chroma/src/haystack_integrations/document_stores/chroma/filters.py Show resolved Hide resolved
integrations/chroma/src/haystack_integrations/document_stores/chroma/filters.py Outdated Show resolved Hide resolved
integrations/chroma/src/haystack_integrations/document_stores/chroma/filters.py Outdated Show resolved Hide resolved
integrations/chroma/src/haystack_integrations/document_stores/chroma/filters.py Outdated Show resolved Hide resolved
@Amnah199 Amnah199 requested a review from shadeMe September 20, 2024 10:01
shadeMe
shadeMe approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@shadeMe shadeMe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 🎉

@Amnah199 Amnah199 merged commit 9fa1853 into main Sep 20, 2024
12 checks passed
@Amnah199 Amnah199 deleted the fix-chroma-filters branch September 20, 2024 12:52
@anakin87 anakin87 mentioned this pull request Sep 30, 2024
Closed
Amnah199 added a commit that referenced this pull request Oct 2, 2024
@Amnah199
fix: filters in chroma integration (#1072)
ee6b7d3
@anakin87 anakin87 mentioned this pull request Oct 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shadeMe shadeMe shadeMe approved these changes

Assignees
No one assigned
Labels
integration:chroma type:documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Using multiple arguments for FilterRetriever
2 participants
@Amnah199 @shadeMe