chore: update Jina Embedder usage for V3 release #1077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@JoanFM could you review the changes please? |
github-actions
bot
added
the
type:documentation
DresAaron
requested review from
Amnah199 and
JoanFM
and removed request for
a team and
JoanFM
DresAaron
commented
Sep 13, 2024
JoanFM
approved these changes
Sep 18, 2024
|
@DresAaron can you please sign the CLA? Can't merge this otherwise. :) |
integrations/jina/src/haystack_integrations/components/embedders/jina/document_embedder.py
Outdated
Show resolved
Hide resolved
integrations/jina/src/haystack_integrations/components/embedders/jina/document_embedder.py
Outdated
Show resolved
Hide resolved
…rs/jina/document_embedder.py Co-authored-by: Silvano Cerza <[email protected]>
…rs/jina/document_embedder.py Co-authored-by: Silvano Cerza <[email protected]>
integrations/jina/src/haystack_integrations/components/embedders/jina/document_embedder.py
Outdated
Show resolved
Hide resolved
integrations/jina/src/haystack_integrations/components/embedders/jina/text_embedder.py
Outdated
Show resolved
Hide resolved
…rs/jina/document_embedder.py Co-authored-by: Silvano Cerza <[email protected]>
…rs/jina/text_embedder.py Co-authored-by: Silvano Cerza <[email protected]>
|
I'll go forward with a new release. :) |
Amnah199
pushed a commit
that referenced
this pull request
Oct 2, 2024
* chore: update Jina Embedder usage for V3 release * fix: resolve lint issue * fix: resolve test error * fix: resolve test error * fix: resolve lint issues * fix: resolve lint issues * fix: resolve lint issues * fix: resolve lint issues * fix: resolve lint issues * chore: update JinaEmbedding for v3 release * fix: resolve test errors * fix: resolve test errors * chore: added test case * fix: resolve lint issues * fix: update function call * fix: resolve lint issues * fix: lint error * fix: lint error * chore: remove unnecessary test cases * chore: use 'task' instead of 'task_type' * chore: add 'late_chunking' for Jina embedders * Update integrations/jina/src/haystack_integrations/components/embedders/jina/document_embedder.py Co-authored-by: Silvano Cerza <[email protected]> * Update integrations/jina/src/haystack_integrations/components/embedders/jina/document_embedder.py Co-authored-by: Silvano Cerza <[email protected]> * Update integrations/jina/src/haystack_integrations/components/embedders/jina/document_embedder.py Co-authored-by: Silvano Cerza <[email protected]> * Update integrations/jina/src/haystack_integrations/components/embedders/jina/text_embedder.py Co-authored-by: Silvano Cerza <[email protected]> --------- Co-authored-by: Silvano Cerza <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.