Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Langfuse: add invocation_context to identify traces #1089

Merged
merged 6 commits into from
Oct 1, 2024

Conversation

vblagoje
Copy link
Member

@ggdupont
Copy link

Any estimate on when this could be merged?

@vblagoje
Copy link
Member Author

Do you find this PR useful @ggdupont ? Can you tell us a bit about your use case please?

@ggdupont
Copy link

Do you find this PR useful @ggdupont ? Can you tell us a bit about your use case please?

I want (at least) to track session id accross calls to the llm just like the original issue. Later I also plan to add conversation metrics for performance monitoring. All should be ligh weigths and simple type metadata so the "invocation_context" seems quite perfect for this.

@vblagoje vblagoje force-pushed the langfuse_invocation_context branch from 0b9d070 to cc16608 Compare October 1, 2024 07:55
@vblagoje
Copy link
Member Author

vblagoje commented Oct 1, 2024

Ok thank you @ggdupont I agree and it seems like a low impact high return PR. Let's see what the peer review says

@vblagoje vblagoje marked this pull request as ready for review October 1, 2024 08:08
@vblagoje vblagoje requested a review from a team as a code owner October 1, 2024 08:08
@vblagoje vblagoje requested review from davidsbatista and removed request for a team October 1, 2024 08:08
@vblagoje vblagoje changed the title WIP - Langfuse: add invocation_context to identify traces Langfuse: add invocation_context to identify traces Oct 1, 2024
@vblagoje vblagoje requested a review from silvanocerza October 1, 2024 08:12
@vblagoje
Copy link
Member Author

vblagoje commented Oct 1, 2024

@silvanocerza please have a look as well and luk your thoughts.

@vblagoje
Copy link
Member Author

vblagoje commented Oct 1, 2024

ping @silvanocerza - have a look now 🙏

@vblagoje vblagoje merged commit 3511eb3 into main Oct 1, 2024
10 checks passed
@vblagoje vblagoje deleted the langfuse_invocation_context branch October 1, 2024 14:45
@vblagoje
Copy link
Member Author

vblagoje commented Oct 1, 2024

Feature included in https://pypi.org/project/langfuse-haystack/0.5.0/ release onward - thanks @silvanocerza @ggdupont @kluhan

@ggdupont
Copy link

ggdupont commented Oct 7, 2024

FYI already integrated and happy of the result.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration:langfuse type:documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants