feat: Add schema support to pgvector document store. #1095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the public schema of a PostgreSQL database is an anti-pattern. This change adds support for using a schema other than the public schema to create tables.
|
|
github-actions
bot
added
integration:pgvector
type:documentation
|
@rblst the idea sounds reasonable. |
anakin87
approved these changes
Nov 14, 2024
Amnah199
pushed a commit
to ttmenezes/haystack-core-integrations
that referenced
this pull request
Nov 15, 2024
* Add schema support for the pgvector document store. Using the public schema of a PostgreSQL database is an anti-pattern. This change adds support for using a schema other than the public schema to create tables. * Fix long lines. * Fix long lines. Remove trailing spaces. * Fix trailing spaces. * Fix last trailing space. * Fix ruff issues. * Fix trailing space. * small fixes --------- Co-authored-by: Stefano Fiorucci <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes:
Add schema support to the pgvector document store.
You can now specify a schema for tables to be created in.
Manually tested these methods:
__init__write_documentsdelete_documentsfilter_documentsdelete_tableFor manual tests, set the
schema_nameattribute, eg.:Notes for the reviewer
The schema must already exist in the database.