Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure CosmosDB Vector Search integration #1099

Closed

Conversation

aayush3011
Copy link

@aayush3011 aayush3011 commented Sep 24, 2024

Related Issues

Azure Cosmos DB Mongo vCore

Azure Cosmos DB NoSql

Proposed Changes:

Added vector search support for Azure Cosmos DB for NoSql and Mongo vCore. It includes all the features mentioned in the links above.

How did you test it?

Added unit tests, and integration tests for testing.

Notes for the reviewer

Checklist

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions github-actions bot added the type:documentation Improvements or additions to documentation label Sep 24, 2024
@aayush3011 aayush3011 marked this pull request as ready for review October 8, 2024 01:41
@aayush3011 aayush3011 requested a review from a team as a code owner October 8, 2024 01:41
@aayush3011 aayush3011 requested review from julian-risch and removed request for a team October 8, 2024 01:41
Copy link
Member

@julian-risch julian-risch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @aayush3011 and thank you for opening this pull request. Please understand that we'll need some time to review it, it's quite a number of lines of code. By the way, have you considered releasing it yourself in a separate repository? We would still list it in the overview of Haystack integrations https://haystack.deepset.ai/integrations/ but the difference would be that you keep ownership of the code.

integrations/azure_cosmos_db_mongo_vcore/README.md Outdated Show resolved Hide resolved
integrations/azure_cosmos_db_mongo_vcore/README.md Outdated Show resolved Hide resolved
integrations/azure_cosmos_db_nosql/README.md Outdated Show resolved Hide resolved
@julian-risch julian-risch requested a review from shadeMe October 8, 2024 15:35
@shadeMe shadeMe removed their request for review October 24, 2024 09:36
@anakin87
Copy link
Member

It seems that we can already use Azure CosmosDB via our existing integrations.
See https://haystack.deepset.ai/integrations/azure-cosmos-db.

I am closing the PR for the moment.

@anakin87 anakin87 closed this Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants