chore: update ruff linting scripts and settings #1105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
integration:instructor-embedders
integration:chroma
integration:elasticsearch
integration:opensearch
integration:unstructured-fileconverter
integration:cohere
integration:jina
integration:google-vertex
integration:qdrant
integration:pinecone
integration:amazon-bedrock
integration:google-ai
integration:ollama
integration:llama_cpp
integration:weaviate
integration:astra
integration:amazon-sagemaker
integration:pgvector
integration:deepeval
integration:fastembed
integration:ragas
integration:mongodb-atlas
integration:mistral
integration:optimum
integration:nvidia
integration:langfuse
labels
anakin87
changed the title
anakin87
changed the title
anakin87
commented
Sep 25, 2024
| @@ -15,7 +15,7 @@ defaults: | |||
| working-directory: integrations/anthropic | |||
|
|
|||
| concurrency: | |||
| group: cohere-${{ github.head_ref }} | |||
| group: anthropic-${{ github.head_ref }} | |||
There was a problem hiding this comment.
unrelated: I noticed that Anthropic tests were not running due to the wrong concurrency group.
Amnah199
reviewed
Sep 26, 2024
| @@ -7,6 +7,7 @@ | |||
| from haystack.components.generators.utils import print_streaming_chunk | |||
| from haystack.dataclasses import ChatMessage, ChatRole, StreamingChunk | |||
| from haystack.utils import Secret | |||
|
|
|||
There was a problem hiding this comment.
Was this intentional? It added extra files in PR.
There was a problem hiding this comment.
yeah, related to formatting...
Amnah199
pushed a commit
that referenced
this pull request
Oct 2, 2024
* updates * more changes * lint * more changes * more changes * mmore and more changes * right concurrency group for anthropic * apply suggestions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes:
I initially noticed that the script
hatch run lint:fmtwas not working -> I replacedruff --fixwithruff check --fix.Then I started noticing some warnings like
warning: The top-level linter settings are deprecated in favour of their counterparts in thelintsection...-> I changed all of them in pyproject files.I also noticed that we introduced scripts like this:
style = ["ruff check {args:. --exclude tests/}",...]in recent PRs.tool.ruff.exclude = ["tests"])-> I removed these expressions and, only where necessary (too much work to adopt linting), replaced them with the appropriate settings in the pyproject file.
How did you test it?
CI, local tests.
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.