Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: pin google-cloud-aiplatform>=1.61 and fix tests #1124

Merged
merged 1 commit into from
Oct 4, 2024
Merged

chore: pin google-cloud-aiplatform>=1.61 and fix tests #1124

merged 1 commit into from
Oct 4, 2024

Conversation

anakin87
Copy link
Member

@anakin87 anakin87 commented Oct 4, 2024

Related Issues

Proposed Changes:

  • to fix the tests, adopt the correct format for FunctionDeclaration, copied from docs.

  • I also verified that our integration only works with google-cloud-aiplatform>=1.61, so I updated the pin

How did you test it?

CI

Checklist

@anakin87 anakin87 marked this pull request as ready for review October 4, 2024 08:57
@anakin87 anakin87 requested a review from a team as a code owner October 4, 2024 08:57
@anakin87 anakin87 requested review from silvanocerza and Amnah199 and removed request for a team October 4, 2024 08:57
@anakin87 anakin87 merged commit cc5defb into main Oct 4, 2024
17 checks passed
@anakin87 anakin87 deleted the fix-vertex-tests branch October 4, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silvanocerza silvanocerza silvanocerza approved these changes

@Amnah199 Amnah199 Awaiting requested review from Amnah199

Assignees
No one assigned
Labels
integration:google-vertex
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anakin87 @silvanocerza