Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make sure that streaming works with function calls - (drop python3.8) #1137

Merged
merged 3 commits into from
Oct 15, 2024

Conversation

anakin87
Copy link
Member

@anakin87 anakin87 commented Oct 15, 2024

Related Issues

Tests are failing: https://github.com/deepset-ai/haystack-core-integrations/actions/runs/11337043949
The conversion of function calls into dictionaries is not working properly.

Proposed Changes:

  • Use the chunk dictionaries to access all required attributes (instead of Google Proto objects).
  • Officially drop Python 3.8 in this package (google-generativeai never supported it)

How did you test it?

CI

Checklist

@github-actions github-actions bot added integration:google-ai type:documentation Improvements or additions to documentation labels Oct 15, 2024
@anakin87 anakin87 marked this pull request as ready for review October 15, 2024 10:06
@anakin87 anakin87 requested a review from a team as a code owner October 15, 2024 10:06
@anakin87 anakin87 requested review from vblagoje and Amnah199 and removed request for a team October 15, 2024 10:06
@anakin87 anakin87 self-assigned this Oct 15, 2024
@anakin87 anakin87 marked this pull request as draft October 15, 2024 10:09
@anakin87 anakin87 marked this pull request as ready for review October 15, 2024 10:12
@Amnah199
Copy link
Contributor

LG! Would you say we should also replace Proto objects approach for below non-stream responses to prevent any failures later?

@anakin87
Copy link
Member Author

LG! Would you say we should also replace Proto objects approach for below non-stream responses to prevent any failures later?

Since this is working now and is covered by tests, I would leave it unchanged. But I leave the decision to you...

(Also, I envision a massive refactoring of this component, when we will add better support for tools.)

@Amnah199
Copy link
Contributor

In that case, makes sense to refactor it once Tools are supported. Thanks for the fix.

@vblagoje
Copy link
Member

@Amnah199 please review this one - I got stuck on other tasks

@anakin87 anakin87 merged commit a722a22 into main Oct 15, 2024
11 checks passed
@anakin87 anakin87 deleted the fix-gemini-function-call-streaming branch October 15, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration:google-ai type:documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants