Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: replace - with _ #114

Merged
merged 3 commits into from
Dec 18, 2023
Merged

chore: replace - with _ #114

merged 3 commits into from
Dec 18, 2023

Conversation

masci
Copy link
Contributor

@masci masci commented Dec 18, 2023

Part of #112

@masci masci requested a review from a team as a code owner December 18, 2023 10:36
@masci masci requested review from anakin87 and removed request for a team December 18, 2023 10:36
@masci masci requested a review from silvanocerza December 18, 2023 10:43
@masci masci mentioned this pull request Dec 18, 2023
Closed
6 tasks
anakin87
anakin87 approved these changes Dec 18, 2023
View reviewed changes
Copy link
Member

@anakin87 anakin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good!

@masci masci merged commit b79939a into main Dec 18, 2023
8 checks passed
@masci masci deleted the massi/112 branch December 18, 2023 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anakin87 anakin87 anakin87 approved these changes

@silvanocerza silvanocerza silvanocerza approved these changes

Assignees
No one assigned
Labels
integration:google-vertex integration:instructor-embedders topic:CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@masci @silvanocerza @anakin87