Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: compatibility with Weaviate 4.9.0 #1143

Merged
merged 3 commits into from
Oct 18, 2024
Merged

fix: compatibility with Weaviate 4.9.0 #1143

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7723e40
compatibiliti with weaviate 4.9.0
anakin87 Oct 17, 2024
ba41fcd
extend from_dict test
anakin87 Oct 18, 2024
965e2b7
Merge branch 'main' into fix-weaviate-4.9
anakin87 Oct 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/weaviate.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ jobs:
fail-fast: false
matrix:
os: [ubuntu-latest]
python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"]
python-version: ["3.9", "3.10", "3.11", "3.12"]

steps:
- uses: actions/checkout@v4
Expand Down
4 changes: 2 additions & 2 deletions integrations/weaviate/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ name = "weaviate-haystack"
dynamic = ["version"]
description = "An integration of Weaviate vector database with Haystack"
readme = "README.md"
requires-python = ">=3.8"
requires-python = ">=3.9"
license = "Apache-2.0"
keywords = []
authors = [{ name = "deepset GmbH", email = "[email protected]" }]
Expand All @@ -25,7 +25,7 @@ classifiers = [
]
dependencies = [
"haystack-ai",
"weaviate-client>=4.0",
"weaviate-client>=4.9",
"haystack-pydoc-tools",
"python-dateutil",
]
Expand Down
3 changes: 3 additions & 0 deletions integrations/weaviate/tests/test_document_store.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,6 +265,7 @@ def test_to_dict(self, _mock_weaviate, monkeypatch):
"session_pool_connections": 20,
"session_pool_maxsize": 100,
"session_pool_max_retries": 3,
"session_pool_timeout": 5,
Amnah199 marked this conversation as resolved.
Show resolved Hide resolved
},
"proxies": {"http": "http://proxy:1234", "https": None, "grpc": None},
"timeout": [30, 90],
Expand Down Expand Up @@ -302,6 +303,7 @@ def test_from_dict(self, _mock_weaviate, monkeypatch):
"connection": {
"session_pool_connections": 20,
"session_pool_maxsize": 20,
"session_pool_timeout": 5,
},
"proxies": {"http": "http://proxy:1234"},
"timeout": [10, 60],
Expand Down Expand Up @@ -338,6 +340,7 @@ def test_from_dict(self, _mock_weaviate, monkeypatch):
assert document_store._embedded_options.grpc_port == DEFAULT_GRPC_PORT
assert document_store._additional_config.connection.session_pool_connections == 20
assert document_store._additional_config.connection.session_pool_maxsize == 20
assert document_store._additional_config.connection.session_pool_timeout == 5

def test_to_data_object(self, document_store, test_files_path):
doc = Document(content="test doc")
Expand Down