-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Update astradb integration for latest client library #1145
feat: Update astradb integration for latest client library #1145
Conversation
Hi @erichare, thanks for this contribution - I've just reverted the |
Thanks! My bad, missed that it was auto generated. I appreciate it! |
@davidsbatista Sorry David, I forgot to mention, but would you (or another maintainer) be able to help with releasing a new version of the Astra integration based on this PR? From the README, it sounds like tagging the commit and doing the CI for it needs to be done by a maintainer. Let me know if you need anything else from me for that. Thanks a lot for the help |
it's done: https://pypi.org/project/astra-haystack/ - I just released it a few minutes ago. |
Fantastic. Thanks again!! |
Related Issues
Proposed Changes:
This update modernizes the Astra DB integration to use the latest
astrapy
client library (>=1.5.0) and the associated improvements that come with it, including fixes for filter conditions and criteria as per the issue above.How did you test it?
I updated and re-ran all Astra DB pytest tests and confirmed successful execution
Notes for the reviewer
Please ensure I correctly bumped the version requirement for
astrapy
as this does requireastrapy>=1.5.0
Checklist
[x] I have read the contributors guidelines and the code of conduct
[x] I have updated the related issue with new insights and changes
[x] I added unit tests and updated the docstrings
[x] I've used one of the conventional commit types for my PR title:
fix:
,feat:
,build:
,chore:
,ci:
,docs:
,style:
,refactor:
,perf:
,test:
.