Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update astradb integration for latest client library #1145

Merged
merged 7 commits into from
Oct 22, 2024

Conversation

erichare
Copy link
Contributor

Related Issues

Proposed Changes:

This update modernizes the Astra DB integration to use the latest astrapy client library (>=1.5.0) and the associated improvements that come with it, including fixes for filter conditions and criteria as per the issue above.

How did you test it?

I updated and re-ran all Astra DB pytest tests and confirmed successful execution

Notes for the reviewer

Please ensure I correctly bumped the version requirement for astrapy as this does require astrapy>=1.5.0

Checklist

[x] I have read the contributors guidelines and the code of conduct
[x] I have updated the related issue with new insights and changes
[x] I added unit tests and updated the docstrings
[x] I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test:.

@erichare erichare requested a review from a team as a code owner October 17, 2024 19:33
@erichare erichare requested review from vblagoje and removed request for a team October 17, 2024 19:33
@julian-risch julian-risch requested review from davidsbatista and removed request for vblagoje October 21, 2024 07:13
@github-actions github-actions bot added the type:documentation Improvements or additions to documentation label Oct 22, 2024
@davidsbatista
Copy link
Contributor

Hi @erichare, thanks for this contribution - I've just reverted the CHANGELOG.md to the original since the changes are added automatically.

@davidsbatista davidsbatista merged commit 067adba into deepset-ai:main Oct 22, 2024
11 checks passed
@erichare erichare deleted the feat-astra-db-updates branch October 22, 2024 13:34
@erichare
Copy link
Contributor Author

Hi @erichare, thanks for this contribution - I've just reverted the CHANGELOG.md to the original since the changes are added automatically.

Thanks! My bad, missed that it was auto generated. I appreciate it!

@erichare
Copy link
Contributor Author

@davidsbatista Sorry David, I forgot to mention, but would you (or another maintainer) be able to help with releasing a new version of the Astra integration based on this PR? From the README, it sounds like tagging the commit and doing the CI for it needs to be done by a maintainer. Let me know if you need anything else from me for that. Thanks a lot for the help

@davidsbatista
Copy link
Contributor

it's done: https://pypi.org/project/astra-haystack/ - I just released it a few minutes ago.

@erichare
Copy link
Contributor Author

Fantastic. Thanks again!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration:astra type:documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'in' operator with AstraEmbeddingRetriever filters in Haystack
2 participants