refactor!: Qdrant - remove index parameter from methods
#1160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
integration:qdrant
type:documentation
anakin87
changed the title
index parameter from some methodsindex parameter from methods
shadeMe
approved these changes
Oct 29, 2024
anakin87
changed the title
index parameter from methodsindex parameter from methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some methods of Qdrant Document Store allow specifying the
indexparameter.This comes from the Haystack 1.x implementation.
In 2.x, we are enforcing the convention where a Document Store corresponds to a specific index/collection.
Having some methods where you can specify
indexis inconsistent and fuels user confusion.See #942
Proposed Changes:
indexparameter from internal and public methodsHow did you test it?
CI
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.