Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fastembed - pin onnxruntime<1.20.0 #1164

Merged
merged 1 commit into from
Nov 4, 2024
Merged

chore: fastembed - pin onnxruntime<1.20.0 #1164

merged 1 commit into from
Nov 4, 2024
+1 −1

Conversation

anakin87
Copy link
Member

@anakin87 anakin87 commented Nov 4, 2024 •
edited
Loading

Related Issues

Proposed Changes:

Temporarily pin onnxruntime<1.20.0.

We should remove this pin in the future: I would expect that fastembed will support onnxruntime<1.20.0 or they will pin the library themselves.

How did you test it?

CI

Checklist

@anakin87 anakin87 marked this pull request as ready for review November 4, 2024 04:47
@anakin87 anakin87 requested a review from a team as a code owner November 4, 2024 04:47
@anakin87 anakin87 requested review from vblagoje and removed request for a team November 4, 2024 04:47
@anakin87 anakin87 changed the title pin onnxruntime chore: fastembed - pin onnxruntime<1.20.0 Nov 4, 2024
@anakin87 anakin87 merged commit 5c4a385 into main Nov 4, 2024
7 checks passed
@anakin87 anakin87 deleted the fastembed-pin-onnxruntime branch November 4, 2024 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vblagoje vblagoje vblagoje approved these changes

Assignees
No one assigned
Labels
integration:fastembed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anakin87 @vblagoje