Add AnthropicVertexChatGenerator component #1192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
type:documentation
Amnah199
changed the title
Comment on lines
+96
to
+97
| self.region = region or os.environ.get("REGION") | ||
| self.project_id = project_id or os.environ.get("PROJECT_ID") |
There was a problem hiding this comment.
These should be Secrets I think. If you do it like this you can leak them when serializing the component.
There was a problem hiding this comment.
In this case project_id and region do not grant access to GCP resources on their own, as proper authentication and permissions are required. So I thought these values are not sensitive data; but more of configuration parameters. Wdyt?
There was a problem hiding this comment.
Good point, we treated them as secrets on some other components though. Good for me to change this.
In any case I would make them mandatory arguments. If the user wants to pass them as env vars that's up to them.
...opic/src/haystack_integrations/components/generators/anthropic/chat/vertex_chat_generator.py
Outdated
Show resolved
Hide resolved
Amnah199
added a commit
to ttmenezes/haystack-core-integrations
that referenced
this pull request
Nov 15, 2024
* Created a model adapter * Create adapter class and add VertexAPI * Add chat generator for Anthropic Vertex * Add tests * Small fix * Improve doc_strings * Make project_id and region mandatory params * Small fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
AnthropicVertexChatGeneratorclass that inherits fromAnthropicChatGeneratorapi_keywith parameters needed forAnthropicVertexHow did you test it?
Notes for the reviewer
A documentation will be created for this component
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.