fix: Fix missing usage metadata in GoogleAIGeminiChatGenerator #1195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
integration:google-ai
type:documentation
anakin87
requested changes
Nov 15, 2024
Comment on lines
320
to
327
| # align openai api response | ||
| usage_metadata = metadata.get("usage_metadata") | ||
| if usage_metadata: | ||
| candidate_metadata["usage"] = { | ||
| "prompt_tokens": usage_metadata["prompt_token_count"], | ||
| "completion_tokens": usage_metadata["candidates_token_count"], | ||
| "total_tokens": usage_metadata["total_token_count"], | ||
| } |
There was a problem hiding this comment.
- my impression is that the key names are wrong. See https://ai.google.dev/api/generate-content#UsageMetadata
- if we want to add this information to each candidate, we should
- use
prompt_tokensas you did - use
completion_tokensfromtokenCountof each candidate (https://ai.google.dev/api/generate-content#v1beta.Candidate) - compute
total_tokensas the sum of the previous to field.
- use
There was a problem hiding this comment.
Ok I was wrong. Google documentation is a bit confusing.
anakin87
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
How did you test it?
Notes for the reviewer
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.