fix: AmazonBedrockChatGenerator with Claude raises moot warning for stream… #1205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
type:documentation
shadeMe
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes a minor update to the
prepare_bodymethod in theamazon_bedrockintegration. The change ensures compatibility with Anthropic by removing the unsupportedstreamkeyword argument frominference_kwargs.We need to leave "stream" kwarg as some other models like Cohere do require it and other LLM foundations models are able to tolerate its presence. We'll soon completely rewrite entire AmazonBedrockChatGenerator codebase to use Converse API anyway.
Note: I didn’t add any new tests but ran the existing ones on CI and locally (for Mistral) to review the logs. While adding new tests would typically be necessary for these fixes I skipped them in this case because we’re planning a complete rewrite of the Amazon Bedrock integration soon anyway.