feat: OllamaDocumentEmbedder - allow batching embeddings
#1224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
latifboubyan
requested review from
davidsbatista
and removed request for
a team
|
|
|
@latifboubyan thanks for your contribution! can you update the docstring of the |
| ] | ||
| reply = embedder.run(list_of_docs) | ||
| assert isinstance(reply, dict) | ||
| assert all(isinstance(element, float) for element in reply["documents"][0].embedding) |
There was a problem hiding this comment.
it seems you are only checking if the first document was embedded - can you make sure are asserting that all the 3 documents have an embedding?
|
overall, looks good to me, I've left too minor comments though - I will also ask @anakin87 to have a quick look |
github-actions
bot
added
the
type:documentation
anakin87
changed the title
OllamaDocumentEmbedder - allow batching embeddings
anakin87
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes:
Use Ollama's batch embedding
How did you test it?
Manual verification as well as adding a unit test.
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.