feat: warn if LangfuseTracer initialized without tracing enabled #1231
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
Add a warning during
LangfuseTracer
initialization in case tracing is disabled.How did you test it?
Tested locally by running the tracer with
LangufuseConnector
in the following cases:haystack.Pipeline
before settingHAYSTACK_CONTENT_TRACING_ENABLED
(warning raised)haystack.Pipeline
after settingHAYSTACK_CONTENT_TRACING_ENABLED
(no warning)Notes for the reviewer
I have not added unit tests because it requires to clear haystack modules and re-import it while having the appropriate HAYSTACK_CONTENT_TRACING_ENABLED env variable set. I though about adding it by removing haystack imports via sys.modules, and re-importing having HAYSTACK_CONTENT_TRACING_ENABLED=false for raising the warning, but apparently by doing so other tests fails, I think I would have to re-import the module while having HAYSTACK_CONTENT_TRACING_ENABLED=true. Let me know if adding a test for it is necessary.
Checklist
fix:
,feat:
,build:
,chore:
,ci:
,docs:
,style:
,refactor:
,perf:
,test:
.