feat: support model_arn in AmazonBedrockGenerator #1244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
integration:amazon-bedrock
type:documentation
julian-risch
requested changes
Dec 11, 2024
| @@ -250,17 +271,28 @@ def run( | |||
| return {"replies": replies} | |||
|
|
|||
| @classmethod | |||
| def get_model_adapter(cls, model: str) -> Optional[Type[BedrockModelAdapter]]: | |||
| def get_model_adapter(cls, model: str, model_family: Optional[str]) -> Type[BedrockModelAdapter]: | |||
| """ | |||
| Gets the model adapter for the given model. | |||
|
|
|||
| :param model: The model name. | |||
There was a problem hiding this comment.
Let's add a docstring for model_family here
There was a problem hiding this comment.
Why not set model_family to None by default?
| ], | ||
| ) | ||
| def test_get_model_adapter(model: str, expected_model_adapter: Optional[Type[BedrockModelAdapter]]): | ||
| """ | ||
| Test that the correct model adapter is returned for a given model | ||
| """ | ||
| model_adapter = AmazonBedrockGenerator.get_model_adapter(model=model) | ||
| model_adapter = AmazonBedrockGenerator.get_model_adapter(model=model, model_family=None) |
There was a problem hiding this comment.
If model_family is set to None by default, we don't need to pass it here explicitly.
| Test that an error is raised when auto-detection of model_family fails | ||
| """ | ||
| with pytest.raises(AmazonBedrockConfigurationError): | ||
| AmazonBedrockGenerator.get_model_adapter(model="arn:123435423", model_family=None) |
There was a problem hiding this comment.
We can leave out model_family=None if we set it to None by default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
model_familyparam which explicitly chooses model adapter if it can't be infered from model nameHow did you test it?
Notes for the reviewer
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.