Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fixes to Bedrock Chat Generator for compatibility with the new ChatMessage #1250

Merged
merged 1 commit into from
Dec 18, 2024
Merged

fix: fixes to Bedrock Chat Generator for compatibility with the new ChatMessage #1250

merged 1 commit into from
Dec 18, 2024

Conversation

anakin87
Copy link
Member

Related Issues

Proposed Changes:

  • Use positional argument in ChatMessage class methods
  • access text instead of content

How did you test it?

Local run with Haystack main branch, CI

Checklist

@anakin87 anakin87 marked this pull request as ready for review December 17, 2024 17:34
@anakin87 anakin87 requested a review from a team as a code owner December 17, 2024 17:34
@anakin87 anakin87 requested review from mpangrazzi and removed request for a team December 17, 2024 17:34
@anakin87 anakin87 merged commit 83f7f69 into main Dec 18, 2024
10 checks passed
@anakin87 anakin87 deleted the bedrock-msg-fix branch December 18, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpangrazzi mpangrazzi mpangrazzi approved these changes

Assignees
No one assigned
Labels
integration:amazon-bedrock
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anakin87 @mpangrazzi